From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 731373858C2D for ; Mon, 8 Jan 2024 07:41:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 731373858C2D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 731373858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704699682; cv=none; b=NXYuTFDGYwsTiqwT2sCpB2elj84q5fu03ZE4kpX86QD9igHkpU6QzVRJdUvmkZ1zWy4ZduXevqabeeskRP7kP7xyj23bjSd+DncrM7va3XTimzCEqOKsEnqvW1YRPkawY6EBy48pZK8eLO+3z5KAG/Lvx8WWse4uDPPAoT2uD0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704699682; c=relaxed/simple; bh=wQSYfXZCa+L5pN2M/aIg3oDrJx9RgJKpgqSKDa9PNeI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sDh/L8+iwdgi8dr9LfM2vxWrGus88shCk6WPpi61jE/rYvI8lJMhDDn8zUfenFHwEguYhqNMapJazS0qSNIsNqpE+ge1VRqEetaBOZuYBVnrtyDZLCFhOg1YQR/af5cpLbwW7B0OOhbEMxXjWikBMGX2LcRKJegWSrEJ31UsiyU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cd0c151cdcso16013871fa.2 for ; Sun, 07 Jan 2024 23:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704699679; x=1705304479; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KI5Szeku21HX9GD6Zgw8OwxXFgbfrmAobh0fbSKNoqE=; b=YL5SG0oME/HVScFWaDJ9ILC1JDyvORDUJHURWKjzxJM7SYCqwRU0aVw0sTOB+X8ArC 1wDl+wMdrkUMMernh7fnf2YGeXmB/hffZe2eq5jxijN6NTDxOOrFJ2MX+Bk0yqHpgyL/ iaMtfaLFb67Svqq2XAlBx3YeFdajwgpa0aUThy0f4CwirV94ZX356DSQARmcZ1KbqMD8 cMdSOdTfIZXE/RlUnnzshUiYRK89eaAyXDzbq09xS08lW+ScNybsWb0ihqIrNFWYHJ2g Taq4b9+zf43HutTd6nBUfuNfZxVl1dSMBfVVTPnsBB99LknoDRUrCbnnwbAmF6nRj9Sz QDYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704699679; x=1705304479; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KI5Szeku21HX9GD6Zgw8OwxXFgbfrmAobh0fbSKNoqE=; b=OBUoX0TtrRqspOCeKKH3bSx7CV68w5+1CLSRu9pINDxikw+kEPrzS+7wYplc7ECyiv 65WXOkONzfTu6znKRX711lYuVLfxetgvo3ck1J+eiEgX5ZmjWZV131pK0iYPI5LWZKoH rBjywiOnV7hfJ3aLtMquossrhS6+k7mBc1lwAlK87F4sETzr2NmcTaZuOwtStIUS/6Tp e6ermuW5MYMfYdXKJG2Jax/9kYt6u+9yRoHCfg5yaI44JlThJasi7xdAgPoBPxgQmWxc y0bd0Xd6Z0f0xtN8jxLav0leXEA1/sGkbINzU6gWRzqHzMoc4ePPKlSMYVUTVAkfgOun BdGw== X-Gm-Message-State: AOJu0YwKwEErbuR1ixBa3fSjT7B3QlDPZ/1JlxH/uY8qRX8JK4GFhG+R BwWY3ZSlBfP3VOBjCD5R3TlCpGB/e44A X-Google-Smtp-Source: AGHT+IGvOF41+/M/I+8ERMe1eUEuitzL/k2BjdJZqIjgJy5h7zzuil2RPE3/ZC6KprF270yyilu2RA== X-Received: by 2002:a2e:94d6:0:b0:2cd:1c9d:4293 with SMTP id r22-20020a2e94d6000000b002cd1c9d4293mr1161822ljh.107.1704699679029; Sun, 07 Jan 2024 23:41:19 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id cn4-20020a056e02388400b00360852ae0e3sm1241457ilb.12.2024.01.07.23.41.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 23:41:18 -0800 (PST) Message-ID: <483e2ffb-fdf0-458b-9900-58c964110a17@suse.com> Date: Mon, 8 Jan 2024 08:41:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 9/9] Support APX JMPABS for disassembler Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Cui, Lili" References: <20231228012714.2989658-1-lili.cui@intel.com> <20231228012714.2989658-10-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.01.2024 03:32, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, January 5, 2024 8:09 PM >> To: Cui, Lili >> Cc: Lu, Hongjiu ; Hu, Lin1 ; >> binutils@sourceware.org >> Subject: Re: [PATCH V5 9/9] Support APX JMPABS for disassembler >> >> On 28.12.2023 02:27, Cui, Lili wrote: >>> --- /dev/null >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s >>> @@ -0,0 +1,15 @@ >>> +# Check bytecode of APX_F jmpabs instructions with illegal encode. >>> + >>> + .text >>> +# With 66 prefix >>> + .byte 0x66,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >>> +# With 67 prefix >>> + .byte 0x67,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >>> +# With F2 prefix >>> + .byte 0xf2,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >>> +# With F3 prefix >>> + .byte 0xf3,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >>> +# With LOCK prefix >>> + .byte 0xf0,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >>> +# REX2.M0 = 0 REX2.W = 1 >>> + .byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >> >> Considering that I specifically asked that this use .insn, and that I further took >> the time to make a patch to make .insn work with {rex2}, I find it rather poor >> that here and ... >> >>> --- /dev/null >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs.s >>> @@ -0,0 +1,5 @@ >>> +# Check 64bit APX_F JMPABS instructions >>> + >>> + .text >>> + _start: >>> + .byte 0xd5,0x00,0xa1,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00 >> >> ... here it is still .byte that is being used. >> > > I'm not always keeping my eye on what patches push in Binutils. That's not a general requirement of course, but when it specifically is work done for you, I would have expected it to be recognized and then leveraged. > We can upstream a new fix patch like this. > .text > # With 66 prefix > - .byte 0x66,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} data16 0xa1, $1{:u64} > # With 67 prefix > - .byte 0x67,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} addr32 0xa1, $1{:u64} > # With F2 prefix > - .byte 0xf2,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} repne 0xa1, $1{:u64} > # With F3 prefix > - .byte 0xf3,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} rep 0xa1, $1{:u64} > # With LOCK prefix > - .byte 0xf0,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} lock 0xa1, $1{:u64} > # REX2.M0 = 0 REX2.W = 1 > - .byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > + .insn {rex2} 0x08,0xa1, $1{:u64} > +#.byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > > But the last test " REX2.M0 = 0 REX2.W = 1" is invalid, do you have some advise? Well, no, as long as {rex2} cannot specify any of the payload bits, and when there are no operands controlling the individual bit (due to there not being any register/memory operands), it can't be easily expressed using .insn. Further work would be required to permit that, but for the time being in _such_ cases it is (of course) okay to use .byte. Jan