From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 08F853858D33 for ; Fri, 12 Apr 2024 01:32:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08F853858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08F853858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712885546; cv=pass; b=nACazqywTrDHpuFuUczru+s/E5q7+9Q+nyhCx25atD5VPTZF3RFTgM4KwzOa2i6gnK4x3GbjCCPIO1Zskm5amr8rB7SFAslv25OKRCAfELninVEyvH/aLqTayWQ3lBPNILgRCeh9UGKAd+Pq4zFCTJ4m0gwZMoFtIoIxGcsp5ZM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712885546; c=relaxed/simple; bh=fBWnKPXS5/tC4oqjuwAgoyZZtLCljFYt7ko6lv/kaz0=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=EV/zAyCKqA6kioNwQqI0A6pjWhkLoqSNF36evrUSPjCgloFuKk+cS5h4oc9Rc0q5Scs2vbRT5a+sM6tMNLDg5ryRTGDP12xrbefJm/S/POLMRQgxpyiwi/EdM38xj9X0S2uDO7kE/JsUwfSQV3U+BeVbJpEtRAY2roiCLmvr+aY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43BJoTkt002335; Fri, 12 Apr 2024 01:32:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=y4AwQF96Rj2WwmgwaYo4W+8XrbFAdPrHRRZ1iVbuKHY=; b=TXVWESC8HQRsPZj8wzjEtXwTjFErK8yUusrC1VejUfY6spnUjrvJ54d/uStF17eNHPzU mMEuuK889f68IflJ3QEBHRZO1epXRzu1g13lN5fnPwo0XonA0DlDcDPdT56lPLYSwyt/ tw0p2gcd3cme6fW+Jn9WwMU7+8Ism9FKywogPYOyqKwDBWnvJ0unnyuc0Lrgh6L1mWNx IDbEJVeSmTUv+iqiX7G9kmAM8o3TLSsVB7AIJg5i7zSP8Qc9UlIdI+uvWmDwfHlZRtKI c3HuYQC4wZ8+LB2/USOnFMgUj8e/iDvfMS1NfMfTk20M7wIz/bFl7BEa3zo6vT5XfAAI 6Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xed4jsn6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Apr 2024 01:32:24 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43BMRRba010514; Fri, 12 Apr 2024 01:32:23 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavuaamkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Apr 2024 01:32:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gK9dKZYuR6Y4R3uX0zfsqmOgQhbVPU0YnE693Bmz/bRLUg+NxVJhjt4nDk0X6irh+WQD09D64VKwXEch61MOqHRgBvXDN35hL1F7bNSmUFhT2UCQmnrYLlXD74q9gVsjPSTyAjfNVbpDRA8TaFbfKtHPeaO5kol8MtDKFBZ5Coy3RbWIqALci/G5vBfvYoes3bdZjFLwCoCq7fEgmSZ/WTKQh827fU40rWJ7zyEfACLg5VmY9LoGJnVtLJ1ILMU1itmQE3O/m4dhhIWo1EoKujemCCvybIFrZT4B4pKDEDqm30fEhpGdfTaFHF41HILu5K8OFZCfweJuwZiJF3XWrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4AwQF96Rj2WwmgwaYo4W+8XrbFAdPrHRRZ1iVbuKHY=; b=CVm/RLqZN5wR/H0AF7x4Y8RUzWijEIeoT7Uam1dz2dChkc2wR/WQzx0MhdWx+fmrcn0qz3HdVAa3Vs7ymeaFwEb8e+MXVljr3gJDZJ5i3ZSsP2KJiUUQ2BGnN6hTutRYx0TkJ7LbY/vxIkIFQaoV6JV7b7uB+dnGR7bzykdEho9lahADS9zLi6rAimcqykmTpm8nYjnsdgz4+BmryCE7S1yFljBk5UbS1Llrt5UnDq8dMkyuLCkdas2wwMt/hQUodVJDRSlGRFXLudWVcdM2cQ2m+/CfvBmQqfU5ZfpIfef4LzFnB4goQEwtO5Sxf+fv7JbLZJQ9HYuD7y9egIAK+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4AwQF96Rj2WwmgwaYo4W+8XrbFAdPrHRRZ1iVbuKHY=; b=kid4MmVXfbh3DnSk6KQpd/GtryI6trj3ahaLk3zV2ET5RyHuFwAtGKZdiBHw5dvAzDoHW0+bHHJwoGJ5cUspOfVAbWPfQM3t2Rw6ppxCLdYQXzbcSivLDgUZnUdFe8eY8Tk9aPAeklNTVq6SOjl+QplmVjESVETevKWBgjd7Uyk= Received: from BN6PR1001MB2147.namprd10.prod.outlook.com (2603:10b6:405:2e::26) by BN0PR10MB5093.namprd10.prod.outlook.com (2603:10b6:408:12d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 01:32:21 +0000 Received: from BN6PR1001MB2147.namprd10.prod.outlook.com ([fe80::dcff:9a4b:28d6:99f8]) by BN6PR1001MB2147.namprd10.prod.outlook.com ([fe80::dcff:9a4b:28d6:99f8%4]) with mapi id 15.20.7409.053; Fri, 12 Apr 2024 01:32:21 +0000 Message-ID: <4891d507-f7d3-428e-8ae8-b99827eb0008@oracle.com> Date: Thu, 11 Apr 2024 18:32:17 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gas: Fix memory leaks in gen-sframe.c Content-Language: en-US To: "H.J. Lu" , binutils@sourceware.org References: <20240411112634.2132551-1-hjl.tools@gmail.com> From: Indu Bhagat In-Reply-To: <20240411112634.2132551-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0043.namprd04.prod.outlook.com (2603:10b6:303:6a::18) To BN6PR1001MB2147.namprd10.prod.outlook.com (2603:10b6:405:2e::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2147:EE_|BN0PR10MB5093:EE_ X-MS-Office365-Filtering-Correlation-Id: b698d3b9-dfb7-4bae-beba-08dc5a9065ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frgcXQejnwS0MYyO/0Hehcpx6doWg8rcN62Q5ZDfL97F4T1ZL2IJxv0RLQZkBMKIAb64VEv/Ls37ovqGcgcDdgbw/1rtc3g95MSMgvL1YsMnAmrTvFHkKt1aS6QpHfY2k81lScGPPBO/YOcjVGg/2tT/tQ74FzDLX2Y/OJq7xN+uuU8qIy8xHAroWsTSTVk7x9MMWybXpTEC0GsO/Rc0UX9gJL6hv4gaIYFor2ts0bxL4thd/0kZq2xZbGmLhSRxAuoLfsP1Y55x2OAGx0aaTSOjIGtlp7c47pax5Yn6A1rLw7zyJ8+W67IZAmFJ3DOGHfvBi/5MDd5+FeHK/NUUK7Y6pF8dozEjR7oH+iCHJjlFiI++Bl7/HubwaSMi5NJ2VnQQNesFxELz6s65N/NxyhGk62dTLb1rBA+GIsmTDSYvncK4j62/G0PZK9Ql3bfwT9YRMMcZDl4kwaGMq32Ncrxac1erD2lMMCaszTbzYRrBC0r6oIQ9deXCuQUh4JZFiMMUFd6THOIG14o9gt5G6/ekEBD3U+U0OFf0l1wxRSIglLc09fLMHrFlWPR0qwJD1lfxoegWTPBIZIZ+O488SrLRH+ztESmUQKnTFmDC5fAjwcydiOllguJcJtNXmQD726y5H2x/B3g1qUWcSxR2xLIsBxw8/2b+ti/0sVc9Nik= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2147.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a00rQjBXVGdOZ3E0dVhuM3QxQjJWVldveFEzSjl0bTRmajI1eVFaS0VEN09M?= =?utf-8?B?TTh1VDlBMWxWN3hma0liS1dOeFhIR2ZodTVYeDduZ0JuVk1TWTVjVXJmd2NZ?= =?utf-8?B?V0dGMWtrc3RmaTdrVkpWQjhsN245Yk1HZjNaM3JqV2Y0dyttdkc4aHhRczVP?= =?utf-8?B?Wjl0VGV4TGs4M0ZhWkVsZkpwUUxuYW5HalI2dCtQU3plVk1iMFppR0czSFhH?= =?utf-8?B?SUtTVmZ5Y3Q4RFM5WXhKcFQvQTh1OWV5cUZYNVd5YkNUeld3ZGU1cWNHWUYz?= =?utf-8?B?WG9jaVR6dWxzWkNUZ1pVUEZMMWx5MFBGcWMwUGZYRjNCSHA0MW82R1ZuaW0x?= =?utf-8?B?K21TNVE3MHlnZUwzSmdBcFpLMU9PV2pHWXZxRitUejhadm9NRjF1dmNZQndV?= =?utf-8?B?emFQSUZQUG1qMGpSdzZQN2cySjIxdjJHZ0xyY0QrRG9VRmRVRmp3Ymx3eFNu?= =?utf-8?B?aENpRE10YkRyVkZxaUtsdnpzcXYxWGVyTW5uZUtzalVQTFpMZHczZ2JLaHFo?= =?utf-8?B?TndWQ2U4RFdES2FkRzliQUdvSWZlSnVWUm8xZXF2T0xjbGlsM0tUNUFJVFht?= =?utf-8?B?QlVtSUVFVFpEM0lrbkVQRDF0bHpEbVVNOGFwWm5Sa0tQS0h4ODQ1SDNNajRy?= =?utf-8?B?Y01oRE8ySndDRUhiS1hidXowUFIwdVlBSUdRdFJ0ejUyYXFKQWpMdXFuZHFO?= =?utf-8?B?QlNxWWlkVGxhcHR3b1JYcVNnZkNMMlpTOG9WcmVLcitRd1ZOM1E1dFRIMDdV?= =?utf-8?B?N2RDTzFCN05IT2JzOS95NUZrSmZRL05EVzZhL2xubXBPOFNOTlFNMytlZFhm?= =?utf-8?B?YlZhYUpHTDVtRXN0dGdDK0xsa0h0UENiUU1kQW9xRlVBclZMY0lpaWxXOWgw?= =?utf-8?B?SzBmalpLdnp3cmlXdTd2SWRyYnJYWW9JcExFUVJSTVpzOEwza0JRMzhuZzRX?= =?utf-8?B?SEdHSjRpNGt1REUrLzhyZ0Vud1JONVBvWkNhdXM0cUhmMmI5UldaZnRSMmVu?= =?utf-8?B?dWhLQ1RNL2tKVUVhUWVHQmp6NHBzbWFURjVsbG1LQmpWaUxYSDI0bnFEYTNr?= =?utf-8?B?NU1qRXBlK0kyOXFZOU9lMGkvZmtNUUp4UzdPeWttN1pKb2dNc1RadnBVQjN0?= =?utf-8?B?cjdPcnpRaFdad2RSTThHZDlJZUZlV1hHNDlmOEI5TmxGOXY2WDVRMmdYVkZC?= =?utf-8?B?OU5EUXQxMXlwelE2aFJZZmhWTWRvTU9TbHR3Y1JCUFhiRFJ5Y1Y5MmNJaU1R?= =?utf-8?B?TzcxK1MydHZwTEM2QlNRMU11SDlwa3I5aGwrRGJHbjN4K0liak5tN0ZiZ0Fr?= =?utf-8?B?QVB3dzkxcjkzNU9oOGRLV1puS0N3dmx6TzBjMEtGRkNCdlA5N0VkOU1DbURt?= =?utf-8?B?T1NPZDFncmM4QTdBdTZHZGhkRm1KZHQ0S2FGTU42NGIySUlRdXhKWUY2QUpN?= =?utf-8?B?NGM0K0JkTFZwOVRsZmVYWHJFbGNrYkppRmppOUN2YSt4L2hjaEpMbGNhOWMz?= =?utf-8?B?QzdrNWFqV1h1S3Y4aU11N0JTZ0FJelNINzBHU01DNEdWaDRTZG9GMVBvVGs1?= =?utf-8?B?QnY3S2ZiYVhWQXdDbHJxTU00MlVZR1g3Ym9STkdtOElKSTc1QmdCRUw1VWFY?= =?utf-8?B?RFlwbkdiYXpFUWxUSk1UVTJkUitMODduQktNSzF0cUZDME1vMGJYSGJaM0Zv?= =?utf-8?B?bzYwRUpRNjM0OEJrNXFsL2xEMVRya2MwM3FOZzZCR0tET1hMZ1Y3MUxlTllI?= =?utf-8?B?cVNiRVVEUHFFTm5idmFsVVhnZXY2aS9MaGd5VmJieFNSUEJGYnFSV2xoTU00?= =?utf-8?B?MXEzZDVNMVlmNHlYOXQ1YWt3eDZZdi82eHFEcDZZYjFROFpsb1BBNmlJWWUx?= =?utf-8?B?c3RNeEQ0Y1QwbVI2b1BCZHZXUTJYbDh1dnVUblJ4bDl2dlhXeFZqTXpoWVZR?= =?utf-8?B?NmtHUmhRRkJYQm1jc0ovMGpWcktKSkZSQmlYNzNDenJ1TTlpVmdOUDlzaWJq?= =?utf-8?B?aFU1dmxUYkxES1RRNG8rbXJxRkpXa1M4bnU2TkNWRDdSWEdFS2V3UGJaQ3hE?= =?utf-8?B?UlNFb016M0gyOWVta2VyT2x2dnZWNnZOQkR0ZkhDU3hzR1ovcGgrcUMzb09r?= =?utf-8?B?Q3dmcld0R3JsR2VOY09NVVdqR1ZqeDRVTXI1bldkRzRwK24rcXB0eXptRkJE?= =?utf-8?Q?xRZUZM7HVWW/AScId4WIboM=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iF0qDy3M/hMVb1YMJPNU3jfi7IqIj2u9UuGwan8YkApd5CfMUVRwdJDB/YPIs5eNNEe5DoNF12R8QM7QJtfbT3yQalzaPwjU91fPpUjDrzo8GfjRLDztJjq6Xmrp/yx5vAJdH83UxpBLLFGVMh3/ATh85c2h0PfjIPwrnr/+zi4Mj+caGD5Nyzg4KUYe+vvWSv5DuDIoDvYW74yVx/w7yg1P+/wmcoMQWnyTizRLJLHm3gr5DThs3AvtXi6JJAlAOJGA3TYYgz4RmHg1NyrdF+agWQBiAU1bJngdJkwFXDqIJAiUSMyhv7BSIlS0aJT8fB+PNrRQ2myX2ythvH9/Ss9ifGyfx/sg9jqNy4VhldMy1KzGPYdHmBTaS4EJZ3h7thSLmcJzt3O/kYET/aXb8yXb6WpAIILRJTyW6RoAcz53Ky03LaTR42ui0vgcsiySgH/JLa5xzX7FT1xwwf7nBRM0fcVStS+Op0uM6fy5x2wfMoe8juMylh3/dHYi5uwCOYIEf++YeWBvTFh+ZNgtwJiChzFa0YCC9PVe2UKxaeb/mkEP4sK5aW6w1TV9N3LfIR0V//k3cI761hmkb6p9zxzKVp8+ypYAzzv5JppKKZs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b698d3b9-dfb7-4bae-beba-08dc5a9065ae X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2147.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:32:20.9966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IV1Ez3FYn2jHFnV571z7R3nMAQiGNRENsWGzhKqCOKM2J7H0kFC6+wuNgajsIq/R1iBSjr4eZRe8rerD6o8/cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5093 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_13,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404120009 X-Proofpoint-GUID: 7iMHI0qer6RHXI_ILzAnBfwzyD_YJRT8 X-Proofpoint-ORIG-GUID: 7iMHI0qer6RHXI_ILzAnBfwzyD_YJRT8 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/11/24 04:26, H.J. Lu wrote: > * gen-sframe.c (sframe_xlate_ctx_cleanup): Call XDELETE on > xlate_ctx->cur_fre. > (create_sframe_all): Call XDELETE on xlate_ctx after use. Thanks for the patch. > --- > gas/gen-sframe.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 75781fc8ccb..25b858e432b 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -847,6 +847,8 @@ sframe_xlate_ctx_cleanup (struct sframe_xlate_ctx *xlate_ctx) > } > } > > + XDELETE (xlate_ctx->cur_fre); > + > sframe_xlate_ctx_init (xlate_ctx); > } > > @@ -1360,6 +1362,8 @@ create_sframe_all (void) > sframe_fde_link (sframe_fde); > } > } > + > + XDELETE (xlate_ctx); > } > > void