From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by sourceware.org (Postfix) with ESMTPS id 977573857342 for ; Thu, 23 Jun 2022 15:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 977573857342 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCBWV91xD7f0YfS0pva7PufWBxXbgF9LxEn3gNgb+2IWhmc/I+fsubjY4KxiqEKpin54Nm5LX+x5S5QWiHqJl4ssjlSJRKsv6Jb9cbpvFogulwMoWgBl6elkkHj6p93lNt5QNNXCdTmZpepCC4j07f/INR+me2Zg3AejvdyppcZ8Bl4IV4hNPmgVzno/aOHRVA81OYSUl37vivA6929nmlfT2WBtOqyQ+yS9Oh1ogfjq8z4nQi6zqZGDXlbfAUOutPspK3RMmmuVy9yNS7U1IXadGXksJAYOkuWziiSktTmAxeuBA0F4GqpVqPzDJzwzKWiExDQWTdrJ/QhWM0RqDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Du+CdqUdDtkhm3UCRiP0Fl2FrwGUuXrelmgwWZ8SkM=; b=HMACnuTq4IIcOwHECaWjSYEpA447+8L9Cs6VR/Jh7j5RKSKud/AaiOW1hQfm4QgN+E2xecH5Ek79u02MRMNeSuOkpBY8aub9nTsk0DBbqC0U6Ajsz8vQpjFTot7eMKP5nWu+SXHnnNkUabXjcdeO9cjzz0xN3RZ/J9ZbxUtldtry4G1QjQruOmI0yzaLjLydokBSmQshT7/hYSjQMEXUA6wSwm5zkAJYlxFcJeP9TJ1FWUIGMeq9ZCPghxQJEIJcDqE2UT7YSm1ACuhuRbXK5V3y4SXKcucsujuvsFK6AxEFswOteXYeCmttMpdw3iNtkc1N47TvpMQX4U64kACs5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9574.eurprd04.prod.outlook.com (2603:10a6:20b:4fc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Thu, 23 Jun 2022 15:40:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 15:40:03 +0000 Message-ID: <48fc0f61-7c17-cd94-be02-31b83dd386ff@suse.com> Date: Thu, 23 Jun 2022 17:40:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 3/6] objcopy: Remove SHT_LLVM_ADDRSIG sections by default. Content-Language: en-US To: Tatsuyuki Ishi Cc: amodra@gmail.com, i@maskray.me, binutils@sourceware.org References: <20220623151353.62139-1-ishitatsuyuki@gmail.com> <20220623151353.62139-4-ishitatsuyuki@gmail.com> From: Jan Beulich In-Reply-To: <20220623151353.62139-4-ishitatsuyuki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0019.eurprd08.prod.outlook.com (2603:10a6:20b:b2::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3278e592-6ca0-434f-528a-08da552ea3ad X-MS-TrafficTypeDiagnostic: AS4PR04MB9574:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kEL5SPiGAG/xoRsLkGw7DYp8Hl2GfTnaMmworL7wFsQGaYpJwkMEvrleOknobJO1s8XweC62jjKMrXnkE7sdzzg641qpO+YQibIVZ2i0n33dKct1/zDJxrHprMK4uHHRkdL00H9TmFYXDRRJ5PSUwgJztxzxU3M2foIfkxs4QI5aiVJQ67Hy0iTGCrDWbaMt72FZosgXhr9lhGgjHAYPMLiuRx5pvacgFM8d9EVJjU8b4VOtKz3pcg6Ma/MTNzVEup5II5tvV88Cin7ZtoLrEF6hzy5jUh+wAteiDbU9K+LZQipsSGoELddVC9C5euSvCP/NICweAemIrrJoA5Bstk3nytUAC+g7I/xaKoPP3LVGYCmP/G6nGmB2zm2jmWIoJjpsyLoRARwKyexhdcHeOedSmmt4fdJQrTyAuSRMEHNmFAaIopYXhfxyw+TQwOXrel5NALnx6tE1UANVL/sp75kpjXfP6Y3HiIZg1pbPa1FMh6TVN57RUlX3cjrxFTIENjZLBtXKqbdlBEzySpZSTq2fGl2OvOPtP5GgODEgyEd4PHC+pjffEv1DEjhJZ0Kxbsde9hLh6c/8tXZioC9Yg0rTXkEUfVom9NckScJhebM2OFbX4mfEnEQRa9sBAQv7n1qC4wlVHuZAy1UzZP/AnR12gpsu/9plPOVmJax1uZl7kbauFbignfUC8db7VZTTPdoEiVnYLZPx8/mEzsVLMy0pkyuKxOz7dOYKbOM8YIDpNysY8GO//bRAnOUAVFQ59qnhz9WiSkISRsXBd69uvBl3MZo2MjDTBl06eCoNQh8FWdHu98nPL3xK4S1+dbIk69UsjiBJmaX9fREhQmueNg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(66476007)(478600001)(186003)(86362001)(4326008)(31696002)(83380400001)(66946007)(6486002)(316002)(8676002)(66556008)(53546011)(5660300002)(38100700002)(31686004)(36756003)(6506007)(8936002)(6512007)(41300700001)(2616005)(26005)(2906002)(6916009)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDc5Z2lsaC83dExCWUErcGpPcHh1Vy9LdVNnUlRHTUNRSVBubFcvaXVyWjlk?= =?utf-8?B?N093TWJtUHR3OGdJalBJQmhrQkwwNnEzSTY0cEhxYStqVStIS3hJV0pZT3M5?= =?utf-8?B?RXNlbFdvQkJJK2ZQS2lxMmN6WVNvemQ5Yi84cFg3SzJvK3FGamdjeUkrL013?= =?utf-8?B?WXBJckhvZjFnSU83TFI4NnZxeFpJY0xoSHlZNERMVDZ1VytIVFEwb0ZXL3hx?= =?utf-8?B?b3htaTFuZWpBd0gzQ1daZTZZZ2JLakxYRG8yaVcxTm1udXJDRDV3RlVDVlZo?= =?utf-8?B?dGU2bUlwWWxxUE5mcTU3WXBHUml0ZFBBUnkwQmxLWG9RSkpvVWhwWUgyUjFX?= =?utf-8?B?MUxqL1gzRFp4aXFZaUpxaU1lVGNEWU5Fd2Q0WUFnY0NFUnZsUTBwUWE1cVc1?= =?utf-8?B?TU5aeFI0SUpnS1FEV2Ivam9XTG5PMGdPSmt2a1dFUUNEdUprSW02cnduSnBD?= =?utf-8?B?QlRYRUs4VGwwYUUvWU1UWHlkYjJVN1RsMUN5b1FuWVZiZ0FnSHhZMEk3ZlJG?= =?utf-8?B?dWdVRWhzZkV1bU1tMWFYT0NsamtCVnJTa1I3MDFZeUdab1hQRy84a3VOaUJv?= =?utf-8?B?bW5qMG9jR1BVdXRKU0FTR2FXMm11ZE1nSXlMeHZTUHJEMmE5U3BzMSt4WlMy?= =?utf-8?B?MjFiLzBNOGZXTEtMQXhxMU93RzN1NkVENVVkTU44bWUydk5iUlJDNUtmaWFF?= =?utf-8?B?cm5HdFdmZVI4elFueWwvTmdZRzBOZzQ3aU1HeVRySC9pMXlsSjFiWE5Ibm1Y?= =?utf-8?B?bHhXWWZlNzRaTXc5azYrL3dlNUQ1NE5VRlVYVnpMVURycmxORk9tYVVCam80?= =?utf-8?B?Z2kwT0hLT2hJTkVaQkZtbTRvQW1lbDF2Z204Qis4WGViekJyZUR4bEFCSGdw?= =?utf-8?B?TmJ4UktvdEVOSVg0eFJvM1ljcGlBM1VHYnM5bFp5Z2VObkJZcE9Jcy9scTFE?= =?utf-8?B?c0hFcGpoRE9Lb0hHQXEzS2h4Tk5XdFhUODJQM3J5eTJnNVo5M0tyd1lTNHpM?= =?utf-8?B?MTFla29jTk4yZ3Q3cHlKYjV3MU8zS3BqSndacjFQdlRTaVQ2QXNHSXNQcEJM?= =?utf-8?B?Y3J4ODNEdVgvVm5rbE8vSHJMOHZZcVlhUnBUeDVTNVRDYVAxWDh0bFp3b254?= =?utf-8?B?ZG9DSXBmNUZoMWlwdXphUzVlZ1NmV0Z5Qk53eHpsK0RiaGVLdjNxNVJ5YmRM?= =?utf-8?B?eWlSeGZuUHlqL2RObGNEMEt5cXdXejZoSzY4SnFXUGd6cXpnT3hhbVB0UGta?= =?utf-8?B?NnFjSWR3L3kybmxqSGZVRjBpSnp6N2FacGZKTUpCVlZWdmgyUlk4cTVWdlg1?= =?utf-8?B?dFAxc0JkNWx4bkNRblJjZmxpb0wwMk5hSjhqRHVVZXByVGtaZldwOU5pUG1X?= =?utf-8?B?a0hsTm5zdXYyMDNQQXZITXZiSUFKUTcvNWtFWUx3a29EOEw5WWJoMTlIdWZV?= =?utf-8?B?di9pN2t3T2tMNWprSGFrRlU2M2t2UXNWSEZtaGFNOFNEYVBzbXR6V1QwK3hC?= =?utf-8?B?OFFTcEF0cmpVTzRNUTZDN2NFTTdOT25NYnNNY0M1TGFtKy9CMkU2UVoyV0lt?= =?utf-8?B?ZTBibUhCWW90N2Y4YXNhWk44NUV4Mnd4ZlRtYXAxWXcyYWoveDJ6cFp6bDJC?= =?utf-8?B?Nm9VeXkvVlQrZWNJcjhva3hBKzJsL2RGM1JMakc4QUk4ZlF3YnJzeDMrRzJC?= =?utf-8?B?RUp6T3pNOUdtcGhTaW8xMS9KVWM4OGFVVlhyeHNCSW5rQmlpUTFJejZlT3A3?= =?utf-8?B?M3Z4NGljY0hrREZZM1cxWm1ULytqUHhhZmRZTytVSkpaNlJ5aDB3cEJxUWFk?= =?utf-8?B?RC85NFVCR3dqQ1Y4RGtqaFZHalJIdGRVZlhKSnRYbEN3ZTNnT3FJZTlqODFZ?= =?utf-8?B?L25GdzVQd05BUTVkMFlobEVUSGZydmc5YmNrOFpiTGlaRnpjOVU1em0rWE9I?= =?utf-8?B?dTZEQk5GSmlGZHZvZVY2S0Y2cWRIMXZ0QURzb2VMVTZMbHp5NW9ZNmdheWtx?= =?utf-8?B?V09BYit5a3ZPUnZiaUhvd201ZTFvM1c2cEkvemdUdjUwYjNvTGRtcms2UUhR?= =?utf-8?B?Z3VhNElGS0k5dXc2ajFic0pGaGsyZksvWTRGU2xvOEdyLzRuem9DTlJMUVdh?= =?utf-8?Q?i8XWXvrWYjqo0Pvz7jen6Kvza?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3278e592-6ca0-434f-528a-08da552ea3ad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 15:40:03.0498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wEglmzco7wDjHsUFRib6SLmE4CRMD7j6uI/V3P3+HMQyJspIYfkFpv7u2qQUCsl5MUyL5ziTOJ6+/4RFIVQaRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9574 X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 15:40:07 -0000 On 23.06.2022 17:13, Tatsuyuki Ishi wrote: > --- a/binutils/objcopy.c > +++ b/binutils/objcopy.c > @@ -1316,10 +1316,20 @@ is_mergeable_note_section (bfd * abfd, asection * sec) > return false; > } > > +static bool > +is_addrsig_section (bfd *abfd, asection *sec) > +{ > + if (bfd_get_flavour (abfd) == bfd_target_elf_flavour > + && elf_section_data (sec)->this_hdr.sh_type == SHT_LLVM_ADDRSIG) > + return true; > + > + return false; > +} Not sure if this would conflict with unwritten style expectations, but when I see such I always wonder: Why not a simple return statement, without explicit use of true/false (or 1/0)? > @@ -1348,6 +1358,20 @@ is_strip_section_1 (bfd *abfd ATTRIBUTE_UNUSED, asection *sec) > return true; > } > > + /* addrsig needs to be updated if the symtab is altered, but we don't know > + how to read nor write it, so just throw it away to not confuse > + downstream tools. */ > + if (is_addrsig_section (abfd, sec)) > + { > + non_fatal (_ ("warning: removing section %s to prevent corrupt addrsig " > + "information"), > + bfd_section_name (sec)); > + non_fatal (_ ("pass --remove-section=%1$s to suppress warning, or " > + "--keep-section=%1$s to override"), > + bfd_section_name (sec)); > + return true; > + } Isn't this too aggressive? The comment says "if the symtab is altered", but the code looks to request stripping unconditionally. Jan