From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2055.outbound.protection.outlook.com [40.107.6.55]) by sourceware.org (Postfix) with ESMTPS id 6682E3858D33 for ; Mon, 6 Nov 2023 15:02:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6682E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6682E3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.55 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699282979; cv=pass; b=UlvbegFW1srwJDM6MS2S/Y3Dt+48y27ITJq3XP3SV/gmbqyVIqp0/eyz+kLUgITFe6bImFr35ybaXI2gBl0KKWBeJ51FB4xsDuKeAHgxhKdd29siJGfbyZOVLFzSljbXudHJgQbkXhSLTkOvRw4hL2eGa7xHCUbxRKVEW6A7GoI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699282979; c=relaxed/simple; bh=TheY974id4onfMp4536zr+dyk6UoexxloFRhrSyRIs8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=CcmtzIecyF7BOBG/HdYTAmOBn5MFABr9EqJsx4IORpGuYN7nOZ2JEUZMFi5rd/sRUq+JXVeDKvY7DRxRY7nXHECmVF/uJmHG33ORKBpy02fCWzZ6NrkSg8MWx9vU4sRznY1kS1JyxJ9fG8nSnMbevKKBZw3R4rH39MElTb2nWCc= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4zn3SUtK8shj0kNfSJzhk236y1cIhdhYLJ1aD3GsPFhXF4G9gvjwUEZ9zDcFLmVGVb5bBgMtZMLWvkdXVsYnhnQz76BFg2aK+mtLGfPN+psrAGxm7laZuD/gpcWOcU+n3/nimjlgOx8oJVYAmVU4hRpsA4T0mPoo+Yu0rAqoEF59q6LhAGXpoVkBQDewzv7AdcCF7Ad9EWWZ90Poyn+C5189w7cFq5z4G74rF1C2IZWwGC5IfY3PIz5M/k6rgL/9KB/Z2c43kNK2Fyg4DYgpkbiK2tVT58xF1j8gtOh7XwWHklnxEyX11oe2/QUpDQKd15fJKq4wRQU6jC1Tco9KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/xfazRqbYI1PgDZFCa/6gNajIEzWnmvv7/x1SfjTNfg=; b=Wd+U5N0TqceM3kh/mwvpHsnygqnOqqS6cQFJdJvrtTHFFuB6pHrk+0e+JsC56zhZA3+PHGQRi+6bk9j5NnQv7I9szORJDMjVu2eABxNJ5KWAhAOD2a2oByNQ5J9VPY35FuqBOrFiRUJ8vzRHRB7oWImnE7nhv4qEm29F8hldkU8mhP1yZigNZfV2KWPyh4haReXeKGul/1fOZkvfEdvrLXgdvmTFtpFQ/ARREPSDGe4TInok2s0FZxL5R2CodoAyM0dzqVNi8JAMj9pQz47DiHkEXCl7os+9sCs7/hecVj7vMzaIr7FtUgH0TYSioOw+WZBJ629YE+GJ787Q/z/bIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/xfazRqbYI1PgDZFCa/6gNajIEzWnmvv7/x1SfjTNfg=; b=LUR06jI+eWH3pu14t1pBECy6urslV5qy3tG0zPlfTLu7NXoLXXQ4Jp1W4yQABDV4a56X3j0t7UuZ18i/vGt5r41Fj1SSKe41vse0L1WMiPXFZy1PHy0sHuliwzJFB9E0Vhh7SR8NepRQUZet/pYqwerTzv6CzIp5996ZPo3aGr2dJRtKZVhNZcz1aZIMw8sg2CWRtHIJFMESjx1K+eWXgQLo67Ac+/PzurRJkvVOhk0+iuSvaB+nF5R7r9ywluz43FsMDVlVrr4fwS3RjH94of0GtZHkAn1xVA/xuIOLJsElct7BccKTzvN9i7pt9izOLwR1JNMRpb6trCryMjNftw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7682.eurprd04.prod.outlook.com (2603:10a6:20b:2db::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.15; Mon, 6 Nov 2023 15:02:46 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.6977.016; Mon, 6 Nov 2023 15:02:46 +0000 Message-ID: <4968f496-b324-e3b3-11f1-a87b62b1aa83@suse.com> Date: Mon, 6 Nov 2023 16:02:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/8] Support APX GPR32 with rex2 prefix Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, ccoutant@gmail.com, binutils@sourceware.org References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-2-lili.cui@intel.com> From: Jan Beulich In-Reply-To: <20231102112911.2372810-2-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0188.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7682:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c02ad4d-2900-4d5f-601b-08dbded96f72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YMCRLXi8ArSb6SrucnlJpcWD8sZuEDLDfrjK6ZGN7RxuYriXiFjIqAFDdJFzh5sA3vKb1TGFYSQ/6Wz/TpiG/M8rH3A1BOdXfCDjFNn5i5cFN4jrlqkiJysTfrN/x0biQzCyVuLZax+tQC/NbrGTKjM3JWHek7ycS4Lc5ybx0NPn00cK9byQpZTw4yS46LndGnuZ601EnpFk3nDq00ww2TLcDQA2oaQAtL6pfBgHXpqqtgLM57o/Q7/2kW6j3ra9BoUPzFjJwCdPaj4qqcgQT0pYXmaNnksdtuxHYEbF03aJIQRJMfQR/RtyL0aXMMvuboq/UZssEQz1AryWi1X7uOfUdVUklhHCdizlDa1u1+7dbRnWp77R8QthwQJuYF15sH498RhI6Aa3GwI9b4EjrXxMNMtxIL4lQS2vcSnt+VcOKBt3F706oPhiOYBqhXWjP1i1ReKh/IXGpCtfMywpJME5pXxAOxyKX0FlkKUe7sjMP0h/R3Www3nWjkTgf3t2LgRXZYItmI3CeaWd7YQl4HOxHMxrERALs8Ep5fxtkSFNXNUFHDz45LXssdFQKkmTQA0asCOrkUplJ0zQajeoyR28jCtfZxx7ubxQsLPSBYTsBih1zdOuTS3jvJhqZGAdqCRTwg89lpOZLYoCwxodr6T12466j1+uK5rdEYyZczM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(396003)(376002)(136003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(2906002)(41300700001)(4326008)(8676002)(8936002)(86362001)(5660300002)(31696002)(36756003)(478600001)(31686004)(966005)(6486002)(6512007)(38100700002)(53546011)(6506007)(66476007)(6916009)(316002)(26005)(66946007)(2616005)(66556008)(533714008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkpPcXptQXBaWEVUYlJqZ1RmNUxHN0JXMkg3TkVYNFExQUVrRXVrVFg3aG5O?= =?utf-8?B?OU91WVl0L3Y3RlhKYnRiZzUvLzlTYm0rVXlHc0VmcUVxVStZbExYNmphYkVv?= =?utf-8?B?Nk1hbGZGNldsY2NlalNlYUcyWndsaEJKc2ZBSzRLd2Qyemw0NHVIZDhCcm1X?= =?utf-8?B?ZmlIUUk2cW9VOHVBT0U4UGIydmV1V0JSMktYdG1LQ20renc2TmgxTlRkL1FD?= =?utf-8?B?KzlGcGVaajZ2c2RSUGpOSkJNT3UzSWo3dTM5amhXdmtleGtWQ1lYa25tQmo4?= =?utf-8?B?aVpqN3FYNWpSK1V0OUYycmhSRkRranNaM3RFbmRSS1AyMTRQdGQrR2pOSURK?= =?utf-8?B?dkNBb0ZvZ0ROUWFOaVczL3V1enZzeE9RZjRXMS9BZnhlRmVKWm5XOWkvMkVn?= =?utf-8?B?bTVxU2FLY2NIZlE1anBjS0xEcWxXLzNqa0lyOGRVY2FWS2lnTUJxakcxSlRz?= =?utf-8?B?V1AyaGY0MHIrcFpBUWFrYmFDdjBTZlVLKzI5S1V1cjQwdFpEVGpPSXlGd1NY?= =?utf-8?B?WVNOazdDNjgzRGswUFpxc2t3UEt5Y1Z5a3FnM0x5ZGkzQjNxNEpKL1haWGJU?= =?utf-8?B?eDRoOE9GZzhtODlvUzFMTXBseC9hdFJtZk92YTdBTCt4QXFTOUFUbzR0eXZF?= =?utf-8?B?TllHTUloYzQ4eEE5aWtIM3E5eEtnV041eW92ZGFUSGsxVEg2MTRmbHNXTHp6?= =?utf-8?B?UGh3MzNIQ09ObVpaRkNJRmhPUmtUcE9QTFJXU2lpczhZVndScEJueE45d2pa?= =?utf-8?B?V0xrYnR2bzBYbEpIbEsxVzFNL3hjUTVwQk5XbTdNbHFmZHA5OVRuZTljeTA2?= =?utf-8?B?NHZuZkpWQTNwTWRvbFg0TmxGZGhYRGJRU2h4dG5hbXF6ZHJXRkVKVnVKdGp3?= =?utf-8?B?MTJSeFpBcU1QNlA5SVhYczRLdVZldnc3cms5UEw2a0NzQWxYbHZkK3ZSc05C?= =?utf-8?B?MUxRR2NQNmk3WjVRVmEvMFFTOVBBcFYrQ0NBRWRLZmM2SmlzMFhDMEtvd3cx?= =?utf-8?B?N1RnTnRHWlhXeUxWQlVETzFoSXVzZFc2OEd2ajFxaEFuT0lCaWV2aVdzaE4x?= =?utf-8?B?S0NXbHoyeU05NzJiUHpOaTNUNXNaaEI1OEpZd01RZTF0N2tTV0k1RFFTOVNM?= =?utf-8?B?TjkzaS81UW9BbzlnS1FBUzR3N3FEVUQxaWxHUzdjU0lVQzN5dk40Tm01c043?= =?utf-8?B?eGQ1THVIR3Bhekw5ZW9uMzJaM0lSNm51Wm00ektiZWJ0aTZDYkljOHl0U3hB?= =?utf-8?B?OG9EbGNZUlA0dmJNa2lwM1FQQnVSY3hISHpWQnZsNFVtc3lRb0ozU1NoMGpL?= =?utf-8?B?K0o0b3dxeFNoS2NoS1B3SVdUV1dtamhoc2FiUmFQakRYUTNPTFpvU2hma3di?= =?utf-8?B?Qk40WDJZeTRKU1NNV3hvZ2VJaGcvSEZUL0xrNUJldHhOYklyVHlFT0VhMTUv?= =?utf-8?B?UkJRYWltWXVkQzZYMzBTMGN3Vm8zcjZiQmw3QWV5MnhSRjFGQU5pM1h6ZHlj?= =?utf-8?B?UG92SUJCMGtoMnRyU0IzejgydWhuSEdvd3NRS1lpaFZMbWhuNEZMZ1J1b2lN?= =?utf-8?B?Nm5mcit5WjlyajkyWFh1b0RVMDVvWXlXYWZnaU5IcmEvRDJWV1VtYittQ09o?= =?utf-8?B?QVd1SDZ6VXVIVndUVGY2elR3NEdMZnZnWWkwRjVUeUkxczN6Y3ErY2JNMWN2?= =?utf-8?B?L1B2RzJjc1BLZjhoVTZIRE42aVlKcUtIdXpCL2FoRmZ2S3VlWExscHBQdTda?= =?utf-8?B?dittZk5ZQkwzTFJlZzVtVlNScHpTRWZ5bG1jb2pIYzdHVlJDc0pWRnJIeXk2?= =?utf-8?B?dHovWXcwMHVnaktqdmZGSW5KWnZRdjlKb0lpQnlaN2ZVK1h6Q1VXVnM1cHp1?= =?utf-8?B?VzBJK0xzVjlmbzdVZTU4NjJnWW1GZzIwZHVodWFpeG5XU3gyL3ZES2piYkZS?= =?utf-8?B?N3lXREw4dndFMTNVZ0loRXkrNVk4Ui9PZ1FSb1NibVV4bnhxcFhnKzVHc0lT?= =?utf-8?B?RnZENk5LMi90dmVUTjB5b0xBYVErazVORElFYTkrL0lKc3pKTWNxei83RERN?= =?utf-8?B?UGxHZmRwYm5jTUxGWWdJOUtldVJONUp0eDhQRWcrUVZMM0U4a25KN2Y4T3VH?= =?utf-8?Q?SDWv+zH0rx6VA2rijJ5oFCz17?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c02ad4d-2900-4d5f-601b-08dbded96f72 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 15:02:46.3170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4559y7N1WS0E7COptf3KR4pcJPR1uuQAJIxAv23vF+NwV+FsIV3QXD2F4oCgn4sPPbv41zJbsG1Hbyc7G9h5kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7682 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.11.2023 12:29, Cui, Lili wrote: > @@ -1119,6 +1148,18 @@ process_i386_opcode_modifier (FILE *table, char *mod, unsigned int space, > fprintf (stderr, > "%s: %d: W modifier without Word/Dword/Qword operand(s)\n", > filename, lineno); > + > + /* The part about judging EVEX encoding should be synchronized with > + is_evex_encoding. */ > + if (modifiers[Vex].value > + || ((space > SPACE_0F || has_special_handle) > + && !modifiers[EVex].value > + && !modifiers[Disp8MemShift].value > + && !modifiers[Broadcast].value > + && !modifiers[Masking].value > + && !modifiers[SAE].value)) > + modifiers[NoEgpr].value = 1; While this is just i386-gen (and hence being somewhat inefficient isn't the end of the world) I still wonder whether we need all the parts of this condition: Do we really need all the constituents of this EVEX related checks? Wouldn't it also help is_evex_encoding() if we switched to uniformly having EVex attributes on all EVEX templates? A presently missing EVex attribute, after all, merely is another way of saying EVexDYN, if I'm not mistaken. (Such an adjustment, if deemed to help, would of course want to come as a separate, prereq patch.) Furthermore, is this correct at all for mixed VEX/EVEX templates? > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -891,7 +891,7 @@ rex.wrxb, 0x4f, x64, NoSuf|IsPrefix, {} > load:Load:0, store:Store:0, + > vex:VEX:0, vex2:VEX:0, vex3:VEX3:0, evex:EVEX:0, + > - rex:REX:x64, nooptimize:NoOptimize:0> > + rex:REX:x64, rex2:REX2:x64, nooptimize:NoOptimize:0> Seeing this I realized that there's something missing here (an APX_F dependency), which then again would not have had an effect without the patch [1] sent earlier today. Jan [1] https://sourceware.org/pipermail/binutils/2023-November/130345.html