From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 66B5F3858D35 for ; Tue, 26 Sep 2023 10:23:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66B5F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34B82DA7; Tue, 26 Sep 2023 03:24:21 -0700 (PDT) Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 891763F6C4; Tue, 26 Sep 2023 03:23:42 -0700 (PDT) Message-ID: <4983b447-4932-fc4e-879f-90a456ff16a6@arm.com> Date: Tue, 26 Sep 2023 11:23:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] aarch64: Restructure feature flag handling Content-Language: en-GB To: Richard Sandiford , binutils@sourceware.org References: <20230925202647.2049600-1-richard.sandiford@arm.com> <20230925202647.2049600-2-richard.sandiford@arm.com> From: "Richard Earnshaw (lists)" In-Reply-To: <20230925202647.2049600-2-richard.sandiford@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3493.0 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/09/2023 21:26, Richard Sandiford via Binutils wrote: > -static const aarch64_feature_set aarch64_feature_v8_5a = > - AARCH64_FEATURE (AARCH64_FEATURE_V8_5A, 0); > + AARCH64_FEATURES (3, F16_FML, F16, FP); > +static const aarch64_feature_set aarch64_feature_v8_5 = > + AARCH64_FEATURE (V8_5A); It looks like this patch hasn't been merged properly with Victor's recent change. The variable name has lost the trailing 'a'. R.