From: "Doug Kwan (關振德)" <dougkwan@google.com>
To: binutils@sourceware.org, Ian Lance Taylor <iant@google.com>
Subject: Re: [PATCH] gold: Fix a minor bug in --exclude-libs.
Date: Tue, 26 May 2009 22:55:00 -0000 [thread overview]
Message-ID: <498552560905261555r5b22c2f1o48fa53490f49d2e@mail.gmail.com> (raw)
In-Reply-To: <498552560905192348t4e0a71echee2d9446c0651cc2@mail.gmail.com>
Patch commited.
2009-05-26 Doug Kwan <dougkwan@google.com>
* options.cc (General_options::parse_exclude_libs). Fix a comment.
(General_options::check_excluded_libs): Strip off directories in
archive name before matching like GNU ld does.
* testsuite/Makefile.am (MOSTLYCLEANFILES,
exclude_libs_test_DEPENDENCIES): Add alt/libexclude_libs_test_3.a
(exclude_libs_test_LDFLAGS): Add linker option
-Wl,--exclude-libs,libexclude_libs_test_3
(exclude_libs_test_LADD): Add alt/libexclude_libs_test_3.a as
an explicit archive without using -l.
(alt/libexclude_libs_test_3.a): New make rule.
* testsuite/Makefile.in: Regenerate.
* testsuite/exclude_libs_test.c : Declare lib3_default().
(main): Call it.
* exclude_libs_test.sh: Add tests for alt/exclude_libs_test_3.a.
* exclude_libs_test_3.c: New file.
2009/5/19 Doug Kwan (關振德) <dougkwan@google.com>:
> A few tests use the alt directory. I'll look at all the tests that
> use alt/ and fix as appropriate.
>
> -Doug
>
> 2009/5/19 Ian Lance Taylor <iant@google.com>:
>> "Doug Kwan (關振德)" <dougkwan@google.com> writes:
>>
>>> 2009/5/19 Ian Lance Taylor <iant@google.com>:
>>>
>>>>> +alt/libexclude_libs_test_3.a: exclude_libs_test_3.o
>>>>> + $(TEST_AR) rc $@ $^
>>>>
>>>> Does this work if the directory "alt" has not already been created?
>>>
>>> I have to checked. If not, I'll fix it. I just copied what other tests do.
>>
>> Ah, it works because the alt/weak_undef_lib.so target creates the alt
>> subdirectory. Please do the same in your patch.
>> test -d alt || mkdir -p alt
>>
>> Ian
>>
>
prev parent reply other threads:[~2009-05-26 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 1:26 Doug Kwan (關振德)
2009-05-20 5:49 ` Ian Lance Taylor
2009-05-20 6:15 ` Doug Kwan (關振德)
2009-05-20 6:27 ` Ian Lance Taylor
2009-05-20 6:49 ` Doug Kwan (關振德)
2009-05-26 22:55 ` Doug Kwan (關振德) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498552560905261555r5b22c2f1o48fa53490f49d2e@mail.gmail.com \
--to=dougkwan@google.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).