From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106573 invoked by alias); 16 Feb 2017 10:16:30 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 106548 invoked by uid 89); 16 Feb 2017 10:16:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=hongjiu.lu@intel.com, U*hongjiu.lu, sk:hongjiu, hongjiuluintelcom X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 10:16:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ED1C54C; Thu, 16 Feb 2017 02:16:18 -0800 (PST) Received: from [10.2.206.198] (e104437-lin.cambridge.arm.com [10.2.206.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F01D93F220; Thu, 16 Feb 2017 02:16:17 -0800 (PST) Subject: Re: [ld, testsuite] Relax the expectation pattern for several plugin-* tests To: Alan Modra References: <20150205135440.GA27203@gmail.com> <20150207094240.GD14796@bubble.grove.modra.org> <54E61565.2090008@arm.com> <355e66f1-d3f6-25e6-1f07-d60fdc7122cf@foss.arm.com> <8e8ac1ef-5410-9251-f6dd-7dc960b65967@foss.arm.com> <20170215234229.GH3731@bubble.grove.modra.org> Cc: "H.J. Lu" , Binutils From: Jiong Wang Message-ID: <49f1398d-2b1b-b220-d43c-846bf45f3de3@foss.arm.com> Date: Thu, 16 Feb 2017 10:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170215234229.GH3731@bubble.grove.modra.org> Content-Type: multipart/mixed; boundary="------------2E159ECBDD6A758DD4A5BCEA" X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00156.txt.bz2 This is a multi-part message in MIME format. --------------2E159ECBDD6A758DD4A5BCEA Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1099 On 15/02/17 23:42, Alan Modra wrote: > On Wed, Feb 15, 2017 at 05:46:46PM +0000, Jiong Wang wrote: >> On 13/02/17 16:57, H.J. Lu wrote: >>> I agree that ARM linker shouldn't complain IR symbols in this case. >>> Can you update ARM linker like this? >> Hmm, I saw BFD_PLUGIN is set together with BFD_LINKER_CREATED, so the current >> check in INTERWORK_FLAG should have covered this. While it is not, so I guess >> in some place bfd linker dropped the BFD_LINKER_CREATED bit. >> >> Some search in the code, it looks to me we should also save "BFD_LINKER_CREATED" >> in BFD_FLAGS_SAVED in bfd.c/bfd-in2.h? I have made this change locally, and >> these failures gone away on arm native ld check without regression. > A patch to add that to BFD_FLAGS_SAVED in bfd.c is preapproved. > Thanks. Committed attached patch after x86/arm native check-ld/as/binutils OK. I followed BFD_FLAGS_FOR_BFD_USE_MASK to put BFD_LINKER_CREATED and BFD_PLUGIN together. bfd/ 2017-02-16 Jiong Wang * bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED. * bfd-in2.h: Regenerated. --------------2E159ECBDD6A758DD4A5BCEA Content-Type: text/x-diff; name="1.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="1.patch" Content-length: 1934 commit 905712060597d0c7a13ffccbca40330c7ad3e3a8 Author: Jiong Wang Date: Thu Feb 16 09:40:03 2017 +0000 [Patch] Add BFD_LINKER_CREATED to BFD_FLAGS_SAVED bfd/ * bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED. * bfd-in2.h: Regenerated. Bug exposed by https://sourceware.org/ml/binutils/2017-02/msg00128.html diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 789915c..a6a4c64 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2017-02-16 Jiong Wang + + * bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED. + * bfd-in2.h: Regenerated. + 2017-02-15 H.J. Lu PR ld/21168 diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h index 80d60cb..f90bb8c 100644 --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -6806,8 +6806,9 @@ struct bfd /* Flags bits to be saved in bfd_preserve_save. */ #define BFD_FLAGS_SAVED \ - (BFD_IN_MEMORY | BFD_COMPRESS | BFD_DECOMPRESS | BFD_PLUGIN \ - | BFD_COMPRESS_GABI | BFD_CONVERT_ELF_COMMON | BFD_USE_ELF_STT_COMMON) + (BFD_IN_MEMORY | BFD_COMPRESS | BFD_DECOMPRESS | BFD_LINKER_CREATED \ + | BFD_PLUGIN | BFD_COMPRESS_GABI | BFD_CONVERT_ELF_COMMON \ + | BFD_USE_ELF_STT_COMMON) /* Flags bits which are for BFD use only. */ #define BFD_FLAGS_FOR_BFD_USE_MASK \ diff --git a/bfd/bfd.c b/bfd/bfd.c index 1607f39..a9402e48 100644 --- a/bfd/bfd.c +++ b/bfd/bfd.c @@ -180,8 +180,9 @@ CODE_FRAGMENT . . {* Flags bits to be saved in bfd_preserve_save. *} .#define BFD_FLAGS_SAVED \ -. (BFD_IN_MEMORY | BFD_COMPRESS | BFD_DECOMPRESS | BFD_PLUGIN \ -. | BFD_COMPRESS_GABI | BFD_CONVERT_ELF_COMMON | BFD_USE_ELF_STT_COMMON) +. (BFD_IN_MEMORY | BFD_COMPRESS | BFD_DECOMPRESS | BFD_LINKER_CREATED \ +. | BFD_PLUGIN | BFD_COMPRESS_GABI | BFD_CONVERT_ELF_COMMON \ +. | BFD_USE_ELF_STT_COMMON) . . {* Flags bits which are for BFD use only. *} .#define BFD_FLAGS_FOR_BFD_USE_MASK \ --------------2E159ECBDD6A758DD4A5BCEA--