From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5214 invoked by alias); 22 May 2014 08:10:35 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 5197 invoked by uid 89); 22 May 2014 08:10:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: qmta10.emeryville.ca.mail.comcast.net Received: from qmta10.emeryville.ca.mail.comcast.net (HELO qmta10.emeryville.ca.mail.comcast.net) (76.96.30.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 08:10:33 +0000 Received: from omta12.emeryville.ca.mail.comcast.net ([76.96.30.44]) by qmta10.emeryville.ca.mail.comcast.net with comcast id 4w8j1o0020x6nqcAAwAYe9; Thu, 22 May 2014 08:10:32 +0000 Received: from up.mrs.kithrup.com ([IPv6:2001:470:81e3::1]) by omta12.emeryville.ca.mail.comcast.net with comcast id 4wAX1o008359mHL8YwAXST; Thu, 22 May 2014 08:10:32 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: as error output not -j64 safe From: Mike Stump In-Reply-To: <20140522072144.GB5162@bubble.grove.modra.org> Date: Thu, 22 May 2014 08:10:00 -0000 Cc: Matthew Fortune , Andrew Pinski , binutils , Richard Sandiford Content-Transfer-Encoding: quoted-printable Message-Id: <4A1F4B1F-7BFF-47D6-9FDC-DC56C9FFDD40@comcast.net> References: <819223B1-7BDF-46C0-80CE-EF49878BA3C8@comcast.net> <36FD025D-0FE1-4248-A154-E28F998F5B73@comcast.net> <20140516085119.GW5162@bubble.grove.modra.org> <6D39441BF12EF246A7ABCE6654B02353539192@LEMAIL01.le.imgtec.org> <6D39441BF12EF246A7ABCE6654B02353539325@LEMAIL01.le.imgtec.org> <9C4FC4FE-EE53-48FA-A599-E03DE182149D@comcast.net> <20140522072144.GB5162@bubble.grove.modra.org> To: Alan Modra X-SW-Source: 2014-05/txt/msg00207.txt.bz2 On May 22, 2014, at 12:21 AM, Alan Modra wrote: > I don't think it matters. We have "Error:" and "Warning:" already in > listing.c, so that should match. >=20 > Hmm, that means in listings we print >=20 > Error:blahblahblah > Life isn't perfect. :) It can be. Try this out, if it tests out ok, either check it in (or let me= know and I can). diff --git a/gas/listing.c b/gas/listing.c index 24450cf..69db6d2 100644 --- a/gas/listing.c +++ b/gas/listing.c @@ -234,10 +234,11 @@ listing_message (const char *name, const char *messag= e) { if (listing_tail !=3D (list_info_type *) NULL) { - unsigned int l =3D strlen (name) + strlen (message) + 1; + unsigned int l =3D strlen (name) + 1 + strlen (message) + 1; char *n =3D (char *) xmalloc (l); struct list_message *lm =3D xmalloc (sizeof *lm); strcpy (n, name); + strcat (n, " "); strcat (n, message); lm->message =3D n; lm->next =3D NULL;