From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1524 invoked by alias); 12 Jun 2009 13:49:35 -0000 Received: (qmail 1512 invoked by uid 22791); 12 Jun 2009 13:49:34 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Jun 2009 13:49:26 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5CDnId8025676; Fri, 12 Jun 2009 09:49:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5CDnGHe013097; Fri, 12 Jun 2009 09:49:17 -0400 Received: from [10.33.6.36] (vpn-6-36.fab.redhat.com [10.33.6.36]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5CDnAdX006579; Fri, 12 Jun 2009 09:49:15 -0400 Message-ID: <4A325CD5.5090204@redhat.com> Date: Fri, 12 Jun 2009 13:49:00 -0000 From: Nick Clifton User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Christophe LYON CC: Phil Blundell , binutils@sourceware.org Subject: Re: linker crash in arm stub generation References: <1244740179.21585.119.camel@mill.internal.reciva.com> <4A324BAC.7090702@redhat.com> <4A3255D9.9030906@st.com> In-Reply-To: <4A3255D9.9030906@st.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00191.txt.bz2 Hi Christophe, > I think your patch is not adequate: it will prevent the stub code from > being generated, but the user code will still jump to the stub. So the > link won't fail, but the result will be wrong. Ah, good point. > Instead, I propose this patch, which prevents mode-switching stub > generation when the call goes through a PLT entry. Thanks! Cheers Nick