From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27984 invoked by alias); 12 Jun 2009 14:13:20 -0000 Received: (qmail 27968 invoked by uid 22791); 12 Jun 2009 14:13:19 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from eu1sys200aog113.obsmtp.com (HELO eu1sys200aog113.obsmtp.com) (207.126.144.135) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Jun 2009 14:13:11 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob113.postini.com ([207.126.147.11]) with SMTP ID DSNKSjJichJRMglQ+O3rrC6iwtiGT1gJUoR2@postini.com; Fri, 12 Jun 2009 14:13:10 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2901C169; Fri, 12 Jun 2009 14:13:02 +0000 (GMT) Received: from mail2.gnb.st.com (mail2.gnb.st.com [164.129.119.59]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E5A574C2B5; Fri, 12 Jun 2009 14:13:01 +0000 (GMT) Received: from [164.129.122.46] (gnx2504.gnb.st.com [164.129.122.46]) by mail2.gnb.st.com (MOS 3.8.7a) with ESMTP id DDT04288 (AUTH lyon); Fri, 12 Jun 2009 16:13:27 +0200 (CEST) Message-ID: <4A32626C.8090407@st.com> Date: Fri, 12 Jun 2009 14:13:00 -0000 From: Christophe LYON User-Agent: Thunderbird 2.0.0.21 (X11/20090302) MIME-Version: 1.0 To: binutils@sourceware.org Cc: Nick Clifton , Phil Blundell Subject: Re: linker crash in arm stub generation References: <1244740179.21585.119.camel@mill.internal.reciva.com> <4A324BAC.7090702@redhat.com> <4A3255D9.9030906@st.com> <20090612140642.GA31950@caradoc.them.org> In-Reply-To: <20090612140642.GA31950@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00196.txt.bz2 On 12.06.2009 16:06, Daniel Jacobowitz wrote: > On Fri, Jun 12, 2009 at 03:19:21PM +0200, Christophe LYON wrote: >> I think your patch is not adequate: it will prevent the stub code from >> being generated, but the user code will still jump to the stub. So the >> link won't fail, but the result will be wrong. >> >> Instead, I propose this patch, which prevents mode-switching stub >> generation when the call goes through a PLT entry. >> >> I think there should already be a test for this in the testsuite, I have >> probably forgotten this configuration. > > This looks good to me - and I agree that a test would be helpful! > I'll propose one + proper ChangeLog entry next week. Christophe.