Results for 2.19.51.20090622 testsuite on i686-pc-cygwin

Results for 2.19.51.20090622 testsuite on i686-pc-cygwin

[Christian Joensson]

Windows XP Pro/SP3 cygwin Intel Core2 Duo T9600@2.80GHz system with packages:

binutils             (local build)  2.19.51.20090609 (daily snapshot)
bison                2.3-1          2.3
cloog-ppl            0.15.3-1
cygwin               1.7.0-50
dejagnu              20021217-2     1.4.2.x
expect               20030128-1     5.26
gcc-ada              3.4.4-999
gcc-core             3.4.4-999
gcc-g++              3.4.4-999
gmp                  4.3.1-3
libcloog-devel       0.15.3-1
libgmp-devel         4.3.1-3
libmpfr-devel        2.4.1-4
libppl               0.10.2-1
make                 3.81-2
mpfr                 2.4.1-4
ppl                  0.10.2-1
ppl-devel            0.10.2-1
tcltk                20080420-1     8.4
w32api               3.13-1

Native configuration is i686-pc-cygwin

		=== binutils tests ===


Running target unix

		=== binutils Summary ===

# of expected passes		92
# of expected failures		1
# of unsupported tests		2
		=== gas tests ===


Running target unix

		=== gas Summary ===

# of expected passes		211
# of expected failures		1
		=== ld tests ===


Running target unix
FAIL: cdtest with -Ur
ERROR: tcl error sourcing
/usr/local/src/trunk/src/ld/testsuite/ld-pe/pe-run.exp.
ERROR: wrong # args: should be "ld_simple_link ld target objects"

		=== ld Summary ===

# of expected passes		82
# of unexpected failures	1
# of expected failures		7
# of unsupported tests		2

version: 2.19.51.20090622 (daily snapshot)
Platform: i686-pc-cygwin
configure flags: --enable-shared --enable-static
BOOT_CFLAGS=-O2 -pipe

[committed] Re: Results for 2.19.51.20090622 testsuite on i686-pc-cygwin

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Christian Joensson wrote:

> Running target unix
> FAIL: cdtest with -Ur
> ERROR: tcl error sourcing
> /usr/local/src/trunk/src/ld/testsuite/ld-pe/pe-run.exp.
> ERROR: wrong # args: should be "ld_simple_link ld target objects"

  <kicks self>  Sigh, I guess the lesson I should learn is "Don't ever even
think you can get away with making whitespace changes between your last test
and committing the code".  >wanders off swearing under his breath about how
rubbish tcl is<

ld/testsuite/ChangeLog:

	* ld-pe/pe-run.exp (proc test_direct_link_dll):  Fix incorrect
	line-wrapping.

  Committed.  I also ate some worms as penitence for messing up.  Thanks for
the heads-up, Christian.

    cheers,
      DaveK

[-- Attachment #2: doh.diff --]
[-- Type: text/x-c, Size: 2092 bytes --]

Index: ld-pe/pe-run.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/pe-run.exp,v
retrieving revision 1.2
diff -p -u -r1.2 pe-run.exp
--- ld-pe/pe-run.exp	18 Jun 2009 02:47:51 -0000	1.2
+++ ld-pe/pe-run.exp	22 Jun 2009 09:33:49 -0000
@@ -83,7 +83,7 @@ proc test_direct_link_dll {} {
 	} else {
 	    # Check linking directly to direct_dll.dll.
 	    set msg "linking client (.dll)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_dll.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_dll.exe \
 	      "$tmpdir/direct_client.o $tmpdir/direct_dll.dll" ] {
 		pass $msg
 	    } else {
@@ -92,7 +92,7 @@ proc test_direct_link_dll {} {
 
 	    # Check linking directly to direct_dll.sl.
 	    set msg "linking client (.sl)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_sl.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_sl.exe \
 	      "$tmpdir/direct_client.o $tmpdir/direct_dll.sl" ] {
 		pass $msg
 	    } else {
@@ -103,7 +103,7 @@ proc test_direct_link_dll {} {
 	    # Create symbolic link.
 	    catch "exec ln -fs direct_dll.dll $tmpdir/libdirect_dll.dll.a" ln_catch
 	    set msg "linking client (symlink -> .dll)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_dll.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_dll.exe \
 	      "$tmpdir/direct_client.o $tmpdir/libdirect_dll.dll.a" ] {
 	        pass $msg
 	    } else {
@@ -114,7 +114,7 @@ proc test_direct_link_dll {} {
 	    # Create symbolic link.
 	    catch "exec ln -fs direct_dll.sl $tmpdir/libdirect_sl.dll.a" ln_catch
 	    set msg "linking client (symlink -> .sl)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_sl.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_sl.exe \
 	      "$tmpdir/direct_client.o $tmpdir/libdirect_sl.dll.a" ] {
 		pass $msg
 	    } else {