public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jie Zhang <jie.zhang@analog.com>
To: binutils@sourceware.org
Subject: [PATCH] Prevent bfin-parse.h being clobbered
Date: Tue, 01 Sep 2009 09:52:00 -0000	[thread overview]
Message-ID: <4A9CEEAA.1050900@analog.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

Rules likes these don't make sense to me:

bfin-defs.h: ; @true
$(srcdir)/config/bfin-defs.h: ; @true

It appears that they should be

bfin-parse.h: ; @true
$(srcdir)/config/bfin-parse.h: ; @true

which are used to prevent .y.h rule clobbering bfin-parse.h.

This patch fixes it. OK?


Jie

[-- Attachment #2: gas-prevent-bfin-parse-h-clobber.diff --]
[-- Type: text/x-patch, Size: 851 bytes --]


	* Makefile.am (bfin-defs.h, $(srcdir)/config/bfin-defs.h):
	Rename to ...
	(bfin-parse.h, $(srcdir)/config/bfin-parse.h): ... these. 
	* Makefile.in: Regenerate.

Index: Makefile.am
===================================================================
RCS file: /cvs/src/src/gas/Makefile.am,v
retrieving revision 1.181
diff -u -r1.181 Makefile.am
--- Makefile.am	26 Aug 2009 18:27:36 -0000	1.181
+++ Makefile.am	1 Sep 2009 09:36:56 -0000
@@ -606,8 +606,8 @@
 bfin-parse.o: bfin-parse.c bfin-parse.h $(srcdir)/config/bfin-defs.h \
  $(INCDIR)/elf/common.h $(INCDIR)/elf/bfin.h $(BFDDIR)/libbfd.h
 
-bfin-defs.h: ; @true
-$(srcdir)/config/bfin-defs.h: ; @true
+bfin-parse.h: ; @true
+$(srcdir)/config/bfin-parse.h: ; @true
 
 bfin-lex.c: $(srcdir)/config/bfin-lex.l
 	$(SHELL) $(YLWRAP) $(srcdir)/config/bfin-lex.l lex.yy.c bfin-lex.c -- $(LEXCOMPILE)


                 reply	other threads:[~2009-09-01  9:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9CEEAA.1050900@analog.com \
    --to=jie.zhang@analog.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).