From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19556 invoked by alias); 5 Sep 2009 12:40:05 -0000 Received: (qmail 19546 invoked by uid 22791); 5 Sep 2009 12:40:04 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_27 X-Spam-Check-By: sourceware.org Received: from nwd2mail11.analog.com (HELO nwd2mail11.analog.com) (137.71.25.57) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Sep 2009 12:39:57 +0000 Received: from nwd2hubcas1.ad.analog.com ([10.64.73.29]) by nwd2mail11.analog.com with ESMTP; 05 Sep 2009 08:39:55 -0400 Received: from nwd2exm5.ad.analog.com (10.64.51.20) by NWD2HUBCAS1.ad.analog.com (10.64.73.29) with Microsoft SMTP Server id 8.1.358.0; Sat, 5 Sep 2009 08:39:55 -0400 Received: from chinexm1.ad.analog.com ([10.99.27.42]) by nwd2exm5.ad.analog.com with Microsoft SMTPSVC(6.0.3790.3959); Sat, 5 Sep 2009 08:39:55 -0400 Received: from [192.168.2.125] ([10.99.29.116]) by chinexm1.ad.analog.com with Microsoft SMTPSVC(6.0.3790.1830); Sat, 5 Sep 2009 20:39:49 +0800 Message-ID: <4AA25BFE.8040106@analog.com> Date: Sat, 05 Sep 2009 12:40:00 -0000 From: Jie Zhang User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Tristan Gingold , Binutils Subject: Re: Binutils branch 2.20 (done!) References: <0BDAACE8-AC5C-4FDC-B647-B95CC534B5D6@adacore.com> <4A9FE8B7.4070403@analog.com> <4AA09EB1.4030408@analog.com> <20090904135833.GT518@bubble.grove.modra.org> In-Reply-To: <20090904135833.GT518@bubble.grove.modra.org> Content-Type: multipart/mixed; boundary="------------030500060806050501060803" X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00153.txt.bz2 --------------030500060806050501060803 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1013 Hi Alan, Alan Modra wrote: > On Fri, Sep 04, 2009 at 12:00:55PM +0200, Tristan Gingold wrote: >> I have just created the 2.20 branch and updated the version on HEAD. >> I will try to do the first prerelease soon. > > Lots of testsuite failures at the moment. It would be nice if target > maintainers would give these some attention. > > bfin-elf/log0:FAIL: flow2 > bfin-elf/log0:FAIL: loop > bfin-elf/log0:FAIL: loop2 > bfin-elf/log0:FAIL: loop3 I don't see these 4 FAILs here. > bfin-elf/log0:FAIL: ld-elf/64ksec-r > bfin-elf/log0:FAIL: ld-elf/64ksec These two FAIL is because Blackfin as does not accept "SYMBOL = VALUE". Blackfin has an algebra assembly syntax. Assigning value to a register has the form: "REG = VALUE" If there is typo of REG, this will become "SYMBOL = VALUE". That error is not easy to notice. So I think it's better to let Blackfin gas reject "SYMBOL = VALUE" to detect such error. .set can be used if user want to set value to a symbol. How about the attached patch? Jie --------------030500060806050501060803 Content-Type: text/x-patch; name="ld-testsuite-sec64k-set-symbole-value.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ld-testsuite-sec64k-set-symbole-value.diff" Content-length: 1760 gas/ * doc/as.texinfo: Document that Blackfin GAS does not accept SYMBOL = VALUE. ld/testsuite/ * ld-elf/sec64k.exp: Use .set instead of = to assign value to symbol. Index: gas/doc/as.texinfo =================================================================== RCS file: /cvs/src/src/gas/doc/as.texinfo,v retrieving revision 1.208 diff -u -r1.208 as.texinfo --- gas/doc/as.texinfo 4 Sep 2009 02:31:44 -0000 1.208 +++ gas/doc/as.texinfo 5 Sep 2009 12:33:06 -0000 @@ -3272,6 +3272,13 @@ equals sign @samp{=}@samp{=} here represents an equivalent of the @code{.eqv} directive. @xref{Eqv,,@code{.eqv}}. +Blackfin has an algebra assembly syntax. +Assigning value to a register has the form @code{REG = VALUE}. +If there is typo of @code{REG}, this will become @code{SYMBOL = VALUE}. +That error is not easy to notice. So it's better to let Blackfin GAS +reject @code{SYMBOL = VALUE} to detect such error. +@code{.set} can be used if user want to set value to a symbol. + @node Symbol Names @section Symbol Names Index: ld/testsuite/ld-elf/sec64k.exp =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-elf/sec64k.exp,v retrieving revision 1.16 diff -u -r1.16 sec64k.exp --- ld/testsuite/ld-elf/sec64k.exp 2 Sep 2009 07:25:39 -0000 1.16 +++ ld/testsuite/ld-elf/sec64k.exp 5 Sep 2009 12:33:07 -0000 @@ -77,9 +77,9 @@ puts $ofd "bar_\\secn:" puts $ofd " .dc.a bar_\\secn" puts $ofd " .endm" - puts $ofd " secn = [expr $i * $secs_per_file]" + puts $ofd " .set secn, [expr $i * $secs_per_file]" puts $ofd " .rept $secs_per_file" - puts $ofd " secn = secn + 1" + puts $ofd " .set secn, secn + 1" puts $ofd " sec %(secn), %(secn-1)" puts $ofd " .endr" --------------030500060806050501060803--