From: David Daney <ddaney@caviumnetworks.com>
To: "\"Doug Kwan (關振德)\"" <dougkwan@google.com>
Cc: Ian Lance Taylor <iant@google.com>,
binutils <binutils@sourceware.org>,
Java List <java@gcc.gnu.org>
Subject: Re: [PATCH][GOLD] Avoid linker crashing when merge sections have uneven sizes.
Date: Fri, 09 Apr 2010 00:48:00 -0000 [thread overview]
Message-ID: <4BBE7915.1050208@caviumnetworks.com> (raw)
In-Reply-To: <o2x498552561004081702h7f92adb9j25ad2faaa652a821@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=Big5, Size: 1203 bytes --]
On 04/08/2010 05:02 PM, Doug Kwan (Ãö®¶¼w) wrote:
> Yes, it looks fishy but I did not dig into the gcc sources. The
> sections are .rodata sections for UTF8 strings for various sizes. It
> looks like the entries are aligned to 32-bit boundaries, not to the
> entsize of a section.
>
FWIW: http://gcc.gnu.org/ml/java-patches/2009-q1/msg00044.html
David Daney
> -Doug
>
> 2010/4/8 Ian Lance Taylor<iant@google.com>:
>> "Doug Kwan (Ãö®¶¼w)"<dougkwan@google.com> writes:
>>
>>> This patch fixes a problem exposed by bootstrapping gcc. libjava
>>> contains objects with unevenly sized merge sections, whose sections
>>> sizes are not multiples of their entsizes.
>>
>> That sounds like a bug somewhere.
>>
>>
>>> 2010-04-08 Doug Kwan<dougkwan@google.com>
>>>
>>> * merge.cc (Output_merge_data::set_final_data_size): Handle empty
>>> Output_merge_data.
>>> * output.cc (Output_section::add_merge_input_section): Simplify
>>> code and return status of Output_merge_base::add_input_section.
>>> Update merge section map only if Output_merge_base::add_input_section
>>> returns true.
>>
>> This is OK.
>>
>> Thanks.
>>
>> Ian
>>
>
prev parent reply other threads:[~2010-04-09 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 23:41 Doug Kwan (關振德)
2010-04-08 23:54 ` Ian Lance Taylor
2010-04-09 0:02 ` Doug Kwan (關振德)
2010-04-09 0:48 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE7915.1050208@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=binutils@sourceware.org \
--cc=dougkwan@google.com \
--cc=iant@google.com \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).