* m68k disassembly patch
@ 2010-05-12 19:20 Jason Duerstock
2010-05-27 10:45 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Jason Duerstock @ 2010-05-12 19:20 UTC (permalink / raw)
To: binutils
The following patch fixes m68k disassembly so that it is easier to
reassemble the disassembled output.
Please let me know if there's anything I need to do to make sure it
gets integrated back into the main source tree, or if there are any
problems with it.
Thanks
Jason
--- opcodes/m68k-dis.c.orig 2010-05-03 14:35:11.000000000 -0400
+++ opcodes/m68k-dis.c 2010-05-03 14:35:47.000000000 -0400
@@ -1623,7 +1623,7 @@
if (val == 0)
/* Handle undefined instructions. */
- info->fprintf_func (info->stream, "0%o", (buffer[0] << 8) + buffer[1]);
+ info->fprintf_func (info->stream, ".short 0x%04x", (buffer[0] <<
8) + buffer[1]);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: m68k disassembly patch
2010-05-12 19:20 m68k disassembly patch Jason Duerstock
@ 2010-05-27 10:45 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2010-05-27 10:45 UTC (permalink / raw)
To: Jason Duerstock; +Cc: binutils
Hi Jason,
> The following patch fixes m68k disassembly so that it is easier to
> reassemble the disassembled output.
>
> Please let me know if there's anything I need to do to make sure it
> gets integrated back into the main source tree, or if there are any
> problems with it.
No, the patch is OK and I have checked it in. (Sorry about taking so
long to review it though).
In the future there are a couple of things that you can do to help the
process:
*) Mention how you tested the patch and whether there were any
testsuite regressions.
*) Provide a ChangeLog entry for the patch. I added this one for yours:
Cheers
Nick
opcodes/ChangeLog
2010-05-27 jason Duerstock <jason.duerstock+binutils@gmail.com>
* m68k-dis.c (print_insn_m68k): Emit undefined instructions as
.short directives so that they can be reassembled.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-27 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-12 19:20 m68k disassembly patch Jason Duerstock
2010-05-27 10:45 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).