From: Dave Korn <dave.korn.cygwin@gmail.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Fix oopsie in ld-plugin tests.
Date: Fri, 15 Oct 2010 18:55:00 -0000 [thread overview]
Message-ID: <4CB8A8FD.4030709@gmail.com> (raw)
In-Reply-To: <201010151810.o9FIAb9i007896@ignucius.se.axis.com>
On 15/10/2010 19:10, Hans-Peter Nilsson wrote:
>> Date: Thu, 14 Oct 2010 06:24:04 +0100
>> From: Dave Korn <dave.korn.cygwin@gmail.com>
>
>> ld/testsuite/ChangeLog:
>>
>> * ld-plugin/plugin.exp: Don't error out if there is no target compiler
>> available, make tests UNSUPPORTED instead.
>
>> +if { !$can_compile || $failed_compile } {
>> foreach testitem $plugin_tests {
>> unresolved [lindex $testitem 0]
>
> Incorrect, or you sent and committed the wrong patch. You made
> them UNRESOLVED, which causes make to (still) return an error.
Sorry, that was what you suggested in your off-list email. Did you mean to
says UNSUPPORTED perhaps?
cheers,
DaveK
next prev parent reply other threads:[~2010-10-15 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 5:01 Dave Korn
[not found] ` <C8993F1F-854C-4D53-8B31-07B2561A9326@adacore.com>
2010-10-14 13:51 ` Dave Korn
2010-10-14 13:56 ` Tristan Gingold
2010-10-15 18:10 ` Hans-Peter Nilsson
2010-10-15 18:55 ` Dave Korn [this message]
2010-10-15 19:02 ` Hans-Peter Nilsson
2010-10-15 19:24 ` [PATCH, take 2] Fix ld-plugin testsuite noise properly [was Re: [PATCH] Fix oopsie in ld-plugin tests.] Dave Korn
2010-10-19 13:13 ` Hans-Peter Nilsson
2010-10-19 23:45 ` Alan Modra
2010-10-20 14:41 ` Dave Korn
2010-10-21 2:14 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB8A8FD.4030709@gmail.com \
--to=dave.korn.cygwin@gmail.com \
--cc=binutils@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).