From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28746 invoked by alias); 24 Oct 2010 01:43:35 -0000 Received: (qmail 28737 invoked by uid 22791); 24 Oct 2010 01:43:34 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_BJ,TW_JF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 Oct 2010 01:43:27 +0000 Received: (qmail 4380 invoked from network); 24 Oct 2010 01:43:25 -0000 Received: from unknown (HELO ?192.168.0.105?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Oct 2010 01:43:25 -0000 Message-ID: <4CC38F4A.7080500@codesourcery.com> Date: Sun, 24 Oct 2010 01:43:00 -0000 From: Mark Mitchell User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.11) Gecko/20101013 Thunderbird/3.1.5 MIME-Version: 1.0 To: Hans-Peter Nilsson CC: iant@google.com, binutils@sourceware.org Subject: Re: RFC: COMDAT group names become anonymouse local symbols References: <201010240102.o9O12S4b029696@ignucius.se.axis.com> In-Reply-To: <201010240102.o9O12S4b029696@ignucius.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00392.txt.bz2 On 10/23/2010 6:02 PM, Hans-Peter Nilsson wrote: > It looks like this patch caused my cris-elf autotester to > regress. Sorry! > I guess your new code is missing an adjustment to > gas/config/obj-multi.[hc] to add obj_adjust_symtab there to > handle (not break for) multi-objformat targets: when obj-elf.c > is compiled as not *the* object-format but one of several, and > when another format is selected. Does that mean adding a new entry to struct format_ops? I'm not familiar with this code, but it looks like struct format_ops is vtable for the format, but right now it doesn't have a adjust_symtab entry. And, how is this supposed to work for something like tc-arm.c which itself overrides the default ELF obj_adjust_symtab? Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713