From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7974 invoked by alias); 26 Oct 2010 15:49:53 -0000 Received: (qmail 7963 invoked by uid 22791); 26 Oct 2010 15:49:53 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 15:49:48 +0000 Received: (qmail 12344 invoked from network); 26 Oct 2010 15:49:46 -0000 Received: from unknown (HELO ?10.155.1.249?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Oct 2010 15:49:46 -0000 Message-ID: <4CC6F89C.5040801@codesourcery.com> Date: Tue, 26 Oct 2010 15:49:00 -0000 From: Mark Mitchell User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.11) Gecko/20101013 Thunderbird/3.1.5 MIME-Version: 1.0 To: Dave Korn CC: Hans-Peter Nilsson , hp@axis.com, iant@google.com, binutils@sourceware.org Subject: Re: RFC: COMDAT group names become anonymouse local symbols References: <201010240334.o9O3YtxO031508@ignucius.se.axis.com> <4CC3B74D.5030501@codesourcery.com> <4CC6FDB9.2060605@gmail.com> In-Reply-To: <4CC6FDB9.2060605@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00437.txt.bz2 On 10/26/2010 12:11 PM, Dave Korn wrote: > ... breaks i686-pc-cygwin, and presumably all other COFF targets: That was the kind of testing I wanted to do, but didn't have a chance to do before I got on the plane. > I tried changing the struct entry to 'coff_adjust_symtab' and the build > completes, but so would putting a null there, like in the ecoff version... > which is right? The former (coff_adjust_symtab) is correct. We're adding a new "adjust_symtab" entry to the "vtable" for object formats; the obj_adjust_smtab hook (as defined in the .h file for the object format) needs to go into the vtable. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713