From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16997 invoked by alias); 26 Oct 2010 15:59:10 -0000 Received: (qmail 16988 invoked by uid 22791); 26 Oct 2010 15:59:10 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 15:59:06 +0000 Received: by wyf23 with SMTP id 23so5105652wyf.0 for ; Tue, 26 Oct 2010 08:59:04 -0700 (PDT) Received: by 10.216.26.138 with SMTP id c10mr1347073wea.23.1288108743834; Tue, 26 Oct 2010 08:59:03 -0700 (PDT) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id k4sm5167656weq.33.2010.10.26.08.59.02 (version=SSLv3 cipher=RC4-MD5); Tue, 26 Oct 2010 08:59:03 -0700 (PDT) Message-ID: <4CC70044.6050102@gmail.com> Date: Tue, 26 Oct 2010 15:59:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Mark Mitchell CC: Hans-Peter Nilsson , hp@axis.com, iant@google.com, binutils@sourceware.org Subject: Re: RFC: COMDAT group names become anonymouse local symbols References: <201010240334.o9O3YtxO031508@ignucius.se.axis.com> <4CC3B74D.5030501@codesourcery.com> <4CC6FDB9.2060605@gmail.com> <4CC6F89C.5040801@codesourcery.com> In-Reply-To: <4CC6F89C.5040801@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00438.txt.bz2 On 26/10/2010 16:49, Mark Mitchell wrote: > On 10/26/2010 12:11 PM, Dave Korn wrote: > >> ... breaks i686-pc-cygwin, and presumably all other COFF targets: > > That was the kind of testing I wanted to do, but didn't have a chance to > do before I got on the plane. NP :) >> I tried changing the struct entry to 'coff_adjust_symtab' and the build >> completes, but so would putting a null there, like in the ecoff version... >> which is right? > > The former (coff_adjust_symtab) is correct. We're adding a new > "adjust_symtab" entry to the "vtable" for object formats; the > obj_adjust_smtab hook (as defined in the .h file for the object format) > needs to go into the vtable. I'll check it in shortly, thanks for getting back to me. cheers, DaveK