From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22084 invoked by alias); 29 Oct 2010 15:12:56 -0000 Received: (qmail 22058 invoked by uid 22791); 29 Oct 2010 15:12:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Oct 2010 15:12:37 +0000 Received: by gyh20 with SMTP id 20so2433181gyh.0 for ; Fri, 29 Oct 2010 08:12:35 -0700 (PDT) Received: by 10.42.216.138 with SMTP id hi10mr1397737icb.327.1288365155677; Fri, 29 Oct 2010 08:12:35 -0700 (PDT) Received: from yakj.usersys.redhat.com (nat-pool-brq-t.redhat.com [209.132.186.34]) by mx.google.com with ESMTPS id y8sm868223vch.29.2010.10.29.08.12.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 29 Oct 2010 08:12:35 -0700 (PDT) Message-ID: <4CCAE45F.20201@gnu.org> Date: Fri, 29 Oct 2010 15:12:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.4 MIME-Version: 1.0 Newsgroups: gmane.comp.gcc.patches To: Matthias Klose CC: Nick Clifton , Mark Mitchell , "Joseph S. Myers" , "H.J. Lu" , Ian Lance Taylor , GCC Patches , binutils Subject: Re: Review of --enable-gold=both patch References: <4C27E695.9070802@codesourcery.com> <4C286200.30402@gnu.org> <4C2886C7.4040408@gnu.org> <4C28CA2A.7060703@codesourcery.com> <4C28CE9C.9030809@gnu.org> <4C28D9F1.6030309@codesourcery.com> <4CC83135.4080603@ubuntu.com> <4CCA91ED.7010909@redhat.com> <4CCAE033.3010009@ubuntu.com> In-Reply-To: <4CCAE033.3010009@ubuntu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00518.txt.bz2 On 10/29/2010 04:54 PM, Matthias Klose wrote: > On 29.10.2010 11:20, Nick Clifton wrote: >> Hi Matthias, >> >>>> OK. I suppose we could also have --with-default-linker=gold -- or >>>> --enable :-) -- but I'm not worried about that. >>>> >>>> Thanks again for your help with this. >>> >>> the --enable-gold=both option is already in current binutils trunk, >>> which will soon be released as binutils-2.21. Should this be changed >>> before the binutils release, or should the binutils patch be kept as it >>> is? Any recommendations how to update the patch and/or current binutils? >> >> We should really make the 2.21 release support --with-default-linker= >> Would you care to submit a patch for this ? > > to summarize: > > - in binutils, --with-default-linker= should trigger which linker is > built, and should determine which linker the ld symlink points to. > > - if both linkers are built, the non-default linker build has to be > enabled with either --enable-ld or --enable-gold. > > - values (other than yes or no) passed to --enable-ld and --enable-gold > are ignored. Uh, actually no. Rereading the thread, the only point on which we had consensus :) was to remove the current wart of --enable-gold disabling --enable-ld; you're proposing to double it instead. This was my proposal: --disable-gold [--enable-ld] Build only ld. Default option. --enable-gold[=default] [--enable-ld] Build both gold and ld. Install gold as "gold" and "ld", install ld as "ld.bfd". This is different from the current behavior, in that ld is currently not installed at all. --enable-gold[=default] --disable-ld Build only gold, which is then installed as both "gold" and "ld". --enable-gold --enable-ld=default Build both gold (installed as "gold") and ld (installed as "ld"). In other words, ld is default --enable-gold=default --enable-ld=default Error. Paolo