From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24286 invoked by alias); 29 Jan 2011 04:11:45 -0000 Received: (qmail 23167 invoked by uid 22791); 29 Jan 2011 04:11:43 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Jan 2011 04:11:36 +0000 Received: by wwi17 with SMTP id 17so3810421wwi.12 for ; Fri, 28 Jan 2011 20:11:34 -0800 (PST) Received: by 10.216.176.138 with SMTP id b10mr8358537wem.75.1296274294482; Fri, 28 Jan 2011 20:11:34 -0800 (PST) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id f27sm2357102wbf.7.2011.01.28.20.11.32 (version=SSLv3 cipher=RC4-MD5); Fri, 28 Jan 2011 20:11:33 -0800 (PST) Message-ID: <4D439979.1010302@gmail.com> Date: Sat, 29 Jan 2011 04:11:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: "H.J. Lu" CC: "binutils@sourceware.org" Subject: Re: [PATCH,trunk+2.21.1] Fix link order problem with LD plugin API. References: <4D437207.4040903@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00388.txt.bz2 On 29/01/2011 02:05, H.J. Lu wrote: > I run your patch on those new LTO tests. I got relevant failures: > > FAIL: LTO 2 > FAIL: LTO 11 > FAIL: LTO 8 > > Your patch doesn't fix any failures and introduce a new one. It's not too bad. The new fail is the assert firing where it can't find a node to insert after when the only claimed objects come from a library; at the moment it's checking the claimed flag only for the overall archive, which is never set. I'll just make it check the claimed flag for the archive members and place the added files after the original archive in that case. LTO 2 passes both before and after on PE-COFF, and LTO 8 is ELF-only, so I'm building the whole thing up on cfarm to see what's going on with those. You didn't mention your target - x86_64-linux, I'm guessing? cheers, DaveK