From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11111 invoked by alias); 11 Feb 2011 20:18:52 -0000 Received: (qmail 11102 invoked by uid 22791); 11 Feb 2011 20:18:51 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dm-mail01.mozilla.org (HELO dm-mail01.mozilla.org) (63.245.208.150) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Feb 2011 20:18:43 +0000 Received: from [10.240.2.241] (v74-nslb.mozilla.org [10.2.74.4]) (Authenticated sender: respindola@mozilla.com) by dm-mail01.mozilla.org (Postfix) with ESMTP id A6979B8035; Fri, 11 Feb 2011 12:18:40 -0800 (PST) Message-ID: <4D559997.6060803@mozilla.com> Date: Fri, 11 Feb 2011 20:18:00 -0000 From: Rafael Avila de Espindola User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: binutils@sourceware.org CC: iant@google.com, dave.korn.cygwin@googlemail.com, ccoutant@google.com Subject: Re: [patch] Fix some plugin API issues in BFD References: <4D52072E.20908@mozilla.com> In-Reply-To: <4D52072E.20908@mozilla.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00113.txt.bz2 ccing Dave and Cary. On 11-02-08 10:17 PM, Rafael Ávila de Espíndola wrote: > I recently updated a plugin to use the file descriptor directly. This > worked fine in gold, but had two issues using bfd (nm and ar): > > *) The filesize was not being set. > *) The code expected the claim_file callback to not seek. > > That is not my understanding from reading the api documentation in > http://gcc.gnu.org/wiki/whopr/driver, so the attached patch fixes both > issues. > > 2010-02-08 Rafael Ávila de Espíndola > > * plugin.c (bfd_plugin_object_p): Correctly set the filesize > and handle claim_file seeking. Cheers, Rafael