From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27303 invoked by alias); 15 Feb 2011 15:55:28 -0000 Received: (qmail 27293 invoked by uid 22791); 15 Feb 2011 15:55:26 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 15:55:21 +0000 Received: by wyj26 with SMTP id 26so316175wyj.0 for ; Tue, 15 Feb 2011 07:55:19 -0800 (PST) Received: by 10.216.51.135 with SMTP id b7mr898916wec.29.1297785319277; Tue, 15 Feb 2011 07:55:19 -0800 (PST) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id o33sm1406859wej.13.2011.02.15.07.55.17 (version=SSLv3 cipher=OTHER); Tue, 15 Feb 2011 07:55:18 -0800 (PST) Message-ID: <4D5AA1FB.2040905@gmail.com> Date: Tue, 15 Feb 2011 15:55:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Kai Tietz CC: Binutils Subject: Re: [patch ld]: Testsuite fix of vers-script-3 and vers-script-4 tests References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00166.txt.bz2 On 15/02/2011 15:30, Kai Tietz wrote: > Ok, I withdraw recent patch. It is just fixing the symptoms but not > the underlying issue. > For 32-bit COFF the real issue is in pe-dll.c file in function > process_def_file_and_drectve. Here the underscore of a symbol is > stripped, and the same time it is done in bfd_demangle, which is used > by bfd_find_version_for_sym. By this in 32-bit case with leading > underscores, they were stripped twice. > > ChangeLog > > 2011-02-15 Kai Tietz > > * pe-dll.c (process_def_file_and_drectve): Don't strip > leading underscore from symbol by calling bfd_find_version_for_sym. > > Tested for x86_64-w64-mingw32, i686-pc-cygwin, and i686-w64-mingw32. > Ok for apply? Nope. This causes two regressions on i686-pc-cygwin: > FAIL: vers-script-3 > FAIL: vers-script-4 They pass currently. They fail with your patch. I'm reasonably sure that I only added that underscore-stripping code when I discovered it to be necessary, but I may not have tested it on a non-prefixing host. I don't understand why you want to remove the underscore stripping code to solve a problem on w64, where it should never be active in any case? cheers, DaveK