From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4525 invoked by alias); 15 Feb 2011 16:07:56 -0000 Received: (qmail 4511 invoked by uid 22791); 15 Feb 2011 16:07:55 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 16:07:51 +0000 Received: by wyj26 with SMTP id 26so328334wyj.0 for ; Tue, 15 Feb 2011 08:07:48 -0800 (PST) Received: by 10.227.137.79 with SMTP id v15mr3974681wbt.196.1297786068404; Tue, 15 Feb 2011 08:07:48 -0800 (PST) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id f27sm2886778wbf.19.2011.02.15.08.07.46 (version=SSLv3 cipher=OTHER); Tue, 15 Feb 2011 08:07:47 -0800 (PST) Message-ID: <4D5AA4E8.70407@gmail.com> Date: Tue, 15 Feb 2011 16:07:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Kai Tietz CC: Binutils Subject: Re: [patch ld]: Testsuite fix of vers-script-3 and vers-script-4 tests References: <4D5AA1FB.2040905@gmail.com> <4D5AA3CA.9050805@gmail.com> In-Reply-To: <4D5AA3CA.9050805@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00168.txt.bz2 On 15/02/2011 16:03, Dave Korn wrote: > On 15/02/2011 15:55, Dave Korn wrote: > >> Nope. This causes two regressions on i686-pc-cygwin: >> >>> FAIL: vers-script-3 >>> FAIL: vers-script-4 >> They pass currently. They fail with your patch. > > > Ah, hang on: I just updated my sandbox, and I have found a suspect change: > >> 2011-02-14 Mike Frysinger <... >> >> * ldlang.c (lang_vers_match): Declare a new c_sym, assign it to >> the bfd_demangle of sym, change users of sym to c_sym when not >> already demangling, and free when done. Change callers of >> cplus_demangle to bfd_demangle. > > > This is likely to have changed the behaviour I guess. Now reading the recent "version scripts and default/C language mangling" and "[PATCH] bfd/ld: handle ABI prefixes in version scripts" threads.. looks like the core handling was made language independent by adding demangling, so removing the pseudo-demangling code in binutils is the correct solution. (I've been a couple of days behind HEAD trying to debug a patchset for the ld plugin api.) Patch is OK after all, thanks! cheers, DaveK