From: "David Stubbs" <stubbs@IceraSemi.com>
To: <binutils@sourceware.org>
Cc: "Alan Modra" <amodra@gmail.com>,
"sdkteam-gnu" <sdkteam-gnu@IceraSemi.com>
Subject: RE: VMA section overlap warnings for overlays
Date: Fri, 07 May 2010 16:14:00 -0000 [thread overview]
Message-ID: <4D60B0700D1DB54A8C0C6E9BE69163700EC60376@EXCHANGEVS.IceraSemi.local> (raw)
In-Reply-To: <20100424021750.GQ3510@bubble.grove.modra.org>
Hi,
If we have a single segment containing a BSS section followed by
overlays then we still get the overlap warning.
Does the following patch look like the correct fix? I believe it fixes
my original test case, and I've also tested it on i686-pc-linux-gnu
without any problems.
Thanks,
Dave.
Bfd/ChangeLog:
2010-05-07 David Stubbs <stubbs@icerasemi.com>
* elf.c (assign_file_positions_for_load_sections): Calculate
adjust
based on file size instead of memory size. Increment p->p_memsz
by
vma based calculation instead of adjust.
Index: bfd/elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.510
diff -u -p -r1.510 elf.c
--- bfd/elf.c 24 Apr 2010 01:05:24 -0000 1.510
+++ bfd/elf.c 7 May 2010 15:41:09 -0000
@@ -4453,17 +4453,17 @@ assign_file_positions_for_load_sections
&& ((this_hdr->sh_flags & SHF_TLS) == 0
|| p->p_type == PT_TLS))))
{
- bfd_vma adjust = sec->lma - (p->p_paddr + p->p_memsz);
+ bfd_vma adjust = sec->lma - (p->p_paddr + p->p_filesz);
- if (sec->lma < p->p_paddr + p->p_memsz)
+ if (sec->lma < p->p_paddr + p->p_filesz)
{
(*_bfd_error_handler)
(_("%B: section %A lma 0x%lx overlaps previous
sections"),
abfd, sec, (unsigned long) sec->lma);
adjust = 0;
- sec->lma = p->p_paddr + p->p_memsz;
+ sec->lma = p->p_paddr + p->p_filesz;
}
- p->p_memsz += adjust;
+ p->p_memsz += sec->vma - (p->p_vaddr + p->p_memsz);
if (this_hdr->sh_type != SHT_NOBITS)
{
next prev parent reply other threads:[~2010-05-07 16:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 13:29 David Stubbs
2010-04-21 8:25 ` Alan Modra
2010-04-21 14:44 ` David Stubbs
2010-04-22 1:11 ` Alan Modra
2010-04-22 1:53 ` Alan Modra
2010-04-22 12:39 ` David Stubbs
2010-04-24 2:18 ` Alan Modra
2010-05-07 16:14 ` David Stubbs [this message]
2010-05-08 11:49 ` Alan Modra
2010-05-12 13:19 ` David Stubbs
2010-05-13 3:37 ` Alan Modra
2010-07-15 8:11 ` Andreas Schwab
2010-07-15 13:10 ` Alan Modra
2010-07-15 13:46 ` Andreas Schwab
2010-07-15 13:53 ` H.J. Lu
2010-07-15 14:12 ` Andreas Schwab
2010-07-15 14:17 ` H.J. Lu
2010-07-15 14:18 ` Alan Modra
2010-07-15 14:26 ` H.J. Lu
2010-07-15 14:36 ` Andreas Schwab
2010-07-15 19:09 ` H.J. Lu
2010-07-16 7:39 ` Andreas Schwab
2010-07-16 10:04 ` Alan Modra
2010-07-19 12:43 ` Andreas Schwab
2010-07-20 5:45 ` Alan Modra
2010-07-20 14:11 ` Alan Modra
2011-02-24 23:49 ` H.J. Lu
2011-02-25 7:49 ` Alan Modra
2011-02-25 10:17 ` Andreas Schwab
2011-02-25 12:30 ` H.J. Lu
2011-02-25 15:55 ` H.J. Lu
2011-02-25 16:23 ` Andreas Schwab
2011-02-25 16:34 ` H.J. Lu
2010-08-28 1:02 ` H.J. Lu
2010-08-28 11:00 ` Alan Modra
2010-08-28 13:39 ` Alan Modra
2010-08-28 17:25 ` H.J. Lu
2010-08-30 4:46 ` Alan Modra
2010-08-30 5:11 ` H.J. Lu
2010-08-30 6:30 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D60B0700D1DB54A8C0C6E9BE69163700EC60376@EXCHANGEVS.IceraSemi.local \
--to=stubbs@icerasemi.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=sdkteam-gnu@IceraSemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).