From: Nick Clifton <nickc@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Binutils <binutils@sourceware.org>,
gdb <gdb@sourceware.org>, Jakub Jelinek <jakub@redhat.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header
Date: Tue, 22 Feb 2011 15:21:00 -0000 [thread overview]
Message-ID: <4D63D49D.90101@redhat.com> (raw)
In-Reply-To: <AANLkTimHC_cR=Zb4JHBhBWcjn0Ypya1uzsjzZZRehSk=@mail.gmail.com>
Hi Kai,
> So this version uses new function dwarf_vma_print function for
> printf-messages, which are getting localized.
>
> Tested for x86_64-w64-mingw32 and x86_64-pc-linux-gnu. Ok for apply?
> +static const char *
> +dwarf_vma_print (const char *fmtch, bfd_vma value)
I think that I prefer your suggestion of dwarf_vmatoa.
> +{
> + static int buf_pos = 0;
> + static struct dwarf_vma_print_buf {
> + char place[64];
> + } buf[16];
Ideally you should have a comment here explaining why you have an array
of these string buffers.
> + char fmt[32];
> + char *ret;
> +
> + sprintf (fmt, "%%%s%s", BFD_VMA_FMT, fmtch);
> + ret = &buf[buf_pos++].place[0];
Or, more simply:
ret = buf[buf_pos++].place;
> + buf_pos &= 15;
That "15" should be: "ARRAY_SIZE (buf) - 1", and it would be safer to write:
buf_pos %= ARRAY_SIZE (buf);
and leave it to the compiler to optimize this into an AND operation if
it can.
> snprintf (ret, 64, fmt, value);
And the "64" here should be "sizeof (buf[0].place)".
Cheers
Nick
next prev parent reply other threads:[~2011-02-22 15:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 14:21 Kai Tietz
2011-02-17 18:59 ` Kai Tietz
2011-02-17 19:03 ` Jakub Jelinek
2011-02-17 19:07 ` Kai Tietz
2011-02-17 19:17 ` Jakub Jelinek
2011-02-18 9:50 ` Kai Tietz
2011-02-21 12:37 ` NightStrike
2011-02-21 13:10 ` Pierre Muller
[not found] ` <-8460070221060995487@unknownmsgid>
2011-02-21 13:27 ` Kai Tietz
2011-02-21 13:46 ` Pierre Muller
[not found] ` <-6930711422310680743@unknownmsgid>
2011-02-21 14:30 ` Kai Tietz
2011-02-21 15:25 ` Kai Tietz
2011-02-21 15:43 ` Mark Kettenis
2011-02-21 15:53 ` Kai Tietz
2011-02-22 15:21 ` Nick Clifton [this message]
2011-02-23 8:59 ` Kai Tietz
2011-02-23 15:12 ` Pierre Muller
[not found] ` <-2339605939192327273@unknownmsgid>
2011-02-23 17:42 ` Kai Tietz
2011-02-23 21:55 ` Pierre Muller
[not found] ` <-3886800211494155692@unknownmsgid>
2011-02-23 22:51 ` H.J. Lu
2011-02-24 11:33 ` Pierre Muller
[not found] ` <1561346207520594884@unknownmsgid>
2011-02-24 13:50 ` H.J. Lu
2011-02-25 10:40 ` [RFC] Use only dwarf_vma types in dwarf code (was RE: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header) Pierre Muller
[not found] ` <5095785081977025060@unknownmsgid>
2011-02-25 12:23 ` Kai Tietz
2011-02-25 13:31 ` Pierre Muller
2011-02-25 13:35 ` [RFC-v2] Use only dwarf_vma types in dwarf code Pierre Muller
2011-03-25 15:16 ` Nick Clifton
2011-03-25 15:48 ` [RFA] Supplemtal patch for use " Pierre Muller
2011-03-25 18:04 ` Nick Clifton
2011-03-25 21:44 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D63D49D.90101@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=jakub@redhat.com \
--cc=ktietz70@googlemail.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).