From: Dave Korn <dave.korn.cygwin@gmail.com>
To: "Rafael Ávila de Espíndola" <respindola@mozilla.com>
Cc: binutils@sourceware.org, iant@google.com, ccoutant@google.com
Subject: Re: [patch] Fix some plugin API issues in BFD
Date: Wed, 23 Feb 2011 15:17:00 -0000 [thread overview]
Message-ID: <4D6524EF.5020302@gmail.com> (raw)
In-Reply-To: <4D6184ED.9020609@mozilla.com>
On 20/02/2011 21:17, Rafael Ãvila de EspÃndola wrote:
> On 2011-02-20 14:54, Rafael Ãvila de EspÃndola wrote:
>> An updated patch is attached that also avoids calling onload multiple times.
>
> Sorry, the correct one is now attached.
Sorry for not answering earlier. I don't have formal approval rights over
this area, so we still need a maintainer, but I can review this patch based on
my experience working in the area.
The parts about only loading the plugin once and setting the filesize in the
(!abfd->my_archive) case are clearly correct. The bit about saving and
restoring the filepos, I had to refresh my memory on, but since we cleared up
the issues around the ownership of the fd passed to the plugin, that's the
right solution too. So AFAIC the patch is OK.
cheers,
DaveK
next prev parent reply other threads:[~2011-02-23 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 3:17 Rafael Ávila de Espíndola
2011-02-11 20:18 ` Rafael Avila de Espindola
2011-02-20 19:55 ` Rafael Ávila de Espíndola
2011-02-20 21:17 ` Rafael Ávila de Espíndola
2011-02-23 15:17 ` Dave Korn [this message]
2011-02-25 20:58 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6524EF.5020302@gmail.com \
--to=dave.korn.cygwin@gmail.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@google.com \
--cc=iant@google.com \
--cc=respindola@mozilla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).