From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14057 invoked by alias); 23 Feb 2011 15:17:28 -0000 Received: (qmail 14049 invoked by uid 22791); 23 Feb 2011 15:17:27 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 15:17:22 +0000 Received: by wyi11 with SMTP id 11so3455246wyi.0 for ; Wed, 23 Feb 2011 07:17:20 -0800 (PST) Received: by 10.227.151.211 with SMTP id d19mr3765182wbw.124.1298474240322; Wed, 23 Feb 2011 07:17:20 -0800 (PST) Received: from [192.168.2.99] (cpc2-cmbg8-0-0-cust61.5-4.cable.virginmedia.com [82.6.108.62]) by mx.google.com with ESMTPS id y29sm668705wbd.4.2011.02.23.07.17.17 (version=SSLv3 cipher=OTHER); Wed, 23 Feb 2011 07:17:18 -0800 (PST) Message-ID: <4D6524EF.5020302@gmail.com> Date: Wed, 23 Feb 2011 15:17:00 -0000 From: Dave Korn User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Rafael_=C1vila_de_Esp=EDndola?= CC: binutils@sourceware.org, iant@google.com, ccoutant@google.com Subject: Re: [patch] Fix some plugin API issues in BFD References: <4D52072E.20908@mozilla.com> <4D61718E.20003@mozilla.com> <4D6184ED.9020609@mozilla.com> In-Reply-To: <4D6184ED.9020609@mozilla.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00282.txt.bz2 On 20/02/2011 21:17, Rafael Ávila de Espíndola wrote: > On 2011-02-20 14:54, Rafael Ávila de Espíndola wrote: >> An updated patch is attached that also avoids calling onload multiple times. > > Sorry, the correct one is now attached. Sorry for not answering earlier. I don't have formal approval rights over this area, so we still need a maintainer, but I can review this patch based on my experience working in the area. The parts about only loading the plugin once and setting the filesize in the (!abfd->my_archive) case are clearly correct. The bit about saving and restoring the filepos, I had to refresh my memory on, but since we cleared up the issues around the ownership of the fd passed to the plugin, that's the right solution too. So AFAIC the patch is OK. cheers, DaveK