From: Michael Snyder <msnyder@vmware.com>
To: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: readelf.c (process_version_sections): Free memory returned by get_data.
Date: Tue, 08 Mar 2011 01:02:00 -0000 [thread overview]
Message-ID: <4D758036.2030504@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
OK?
[-- Attachment #2: readelf2.txt --]
[-- Type: text/plain, Size: 1517 bytes --]
2011-03-07 Michael Snyder <msnyder@vmware.com>
* readelf.c (process_version_sections): Free memory returned by
get_data.
Index: readelf.c
===================================================================
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.534
diff -u -p -r1.534 readelf.c
--- readelf.c 1 Mar 2011 00:02:32 -0000 1.534
+++ readelf.c 8 Mar 2011 00:59:06 -0000
@@ -8194,6 +8198,7 @@ process_version_sections (FILE * file)
Elf_Internal_Verdef ivd;
Elf_External_Verdef evd;
unsigned long offset;
+ void *tmp;
offset = offset_from_vma
(file, version_info[DT_VERSIONTAGIDX (DT_VERDEF)],
@@ -8201,8 +8206,10 @@ process_version_sections (FILE * file)
do
{
- get_data (&evd, file, offset, sizeof (evd), 1,
- _("version def"));
+ tmp = get_data (&evd, file, offset,
+ sizeof (evd), 1,
+ _("version def"));
+ free (tmp);
ivd.vd_next = BYTE_GET (evd.vd_next);
ivd.vd_ndx = BYTE_GET (evd.vd_ndx);
@@ -8219,10 +8226,11 @@ process_version_sections (FILE * file)
ivd.vd_aux = BYTE_GET (evd.vd_aux);
- get_data (&evda, file,
- offset - ivd.vd_next + ivd.vd_aux,
- sizeof (evda), 1,
- _("version def aux"));
+ tmp = get_data (&evda, file,
+ offset - ivd.vd_next + ivd.vd_aux,
+ sizeof (evda), 1,
+ _("version def aux"));
+ free (tmp);
ivda.vda_name = BYTE_GET (evda.vda_name);
next reply other threads:[~2011-03-08 1:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 1:02 Michael Snyder [this message]
2011-03-14 12:14 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D758036.2030504@vmware.com \
--to=msnyder@vmware.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).