From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1580 invoked by alias); 8 Mar 2011 21:07:53 -0000 Received: (qmail 1572 invoked by uid 22791); 8 Mar 2011 21:07:52 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SHORT_BODY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 21:07:48 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id C0C3D130FD for ; Tue, 8 Mar 2011 13:07:46 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id B78A5CD9F0 for ; Tue, 8 Mar 2011 13:07:46 -0800 (PST) Message-ID: <4D769AA2.9030105@vmware.com> Date: Tue, 08 Mar 2011 21:07:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "binutils@sourceware.org" Subject: [RFA] ieee.c, plug several memory leaks. Content-Type: multipart/mixed; boundary="------------070008020504010600000100" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00160.txt.bz2 This is a multi-part message in MIME format. --------------070008020504010600000100 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 OK? --------------070008020504010600000100 Content-Type: text/plain; name="ieee.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ieee.txt" Content-length: 1693 2011-03-08 Michael Snyder * ieee.c (ieee_add_bb11): Plug memory leak. (ieee_function_type): Ditto. (ieee_class_baseclass): Ditto. Index: ieee.c =================================================================== RCS file: /cvs/src/src/binutils/ieee.c,v retrieving revision 1.28 diff -u -p -r1.28 ieee.c --- ieee.c 28 Feb 2011 18:32:51 -0000 1.28 +++ ieee.c 8 Mar 2011 21:05:01 -0000 @@ -5125,7 +5125,10 @@ ieee_add_bb11 (struct ieee_handle *info, || ! ieee_write_id (info, "") || ! ieee_write_number (info, 0) || ! ieee_write_id (info, "GNU objcopy")) - return FALSE; + { + free (c); + return FALSE; + } free (c); } @@ -5529,7 +5532,10 @@ ieee_function_type (void *p, int argcoun || ! ieee_write_number (info, 0) || ! ieee_write_number (info, retindx) || ! ieee_write_number (info, (bfd_vma) argcount + (varargs ? 1 : 0))) - return FALSE; + { + free (args); + return FALSE; + } if (argcount > 0) { for (i = 0; i < argcount; i++) @@ -6235,7 +6241,10 @@ ieee_class_baseclass (void *p, bfd_vma b || ! ieee_write_id (info, fname) || ! ieee_write_number (info, bindx) || ! ieee_write_number (info, bitpos / 8)) - return FALSE; + { + free (fname); + return FALSE; + } flags = 0; } @@ -6250,7 +6259,10 @@ ieee_class_baseclass (void *p, bfd_vma b || ! ieee_write_atn65 (info, nindx, bname) || ! ieee_write_asn (info, nindx, 0) || ! ieee_write_atn65 (info, nindx, fname)) - return FALSE; + { + free (fname); + return FALSE; + } info->type_stack->type.classdef->pmisccount += 5; free (fname); --------------070008020504010600000100--