From: Michael Snyder <msnyder@vmware.com>
To: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: [RFA] bucomm.c (make_tempname): Stop memory leak.
Date: Tue, 08 Mar 2011 22:57:00 -0000 [thread overview]
Message-ID: <4D76B43A.3030300@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
OK?
[-- Attachment #2: bucomm.txt --]
[-- Type: text/plain, Size: 606 bytes --]
2011-03-08 Michael Snyder <msnyder@vmware.com>
* bucomm.c (make_tempname): Stop memory leak.
Index: bucomm.c
===================================================================
RCS file: /cvs/src/src/binutils/bucomm.c,v
retrieving revision 1.42
diff -u -p -r1.42 bucomm.c
--- bucomm.c 6 Jan 2011 11:34:28 -0000 1.42
+++ bucomm.c 8 Mar 2011 22:55:10 -0000
@@ -511,7 +511,10 @@ make_tempname (char *filename)
fd = open (tmpname, O_RDWR | O_CREAT | O_EXCL, 0600);
#endif
if (fd == -1)
- return NULL;
+ {
+ free (tmpname);
+ return NULL;
+ }
close (fd);
return tmpname;
}
next reply other threads:[~2011-03-08 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 22:57 Michael Snyder [this message]
2011-03-25 17:51 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D76B43A.3030300@vmware.com \
--to=msnyder@vmware.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).