* [RFA] ar.c (move_members): Plug memory leak.
@ 2011-03-08 20:20 Michael Snyder
2011-03-25 17:14 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Michael Snyder @ 2011-03-08 20:20 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
OK?
[-- Attachment #2: ar2.txt --]
[-- Type: text/plain, Size: 1386 bytes --]
2011-03-08 Michael Snyder <msnyder@vmware.com>
* ar.c (move_members): Plug memory leak.
Index: ar.c
===================================================================
RCS file: /cvs/src/src/binutils/ar.c,v
retrieving revision 1.72
diff -u -p -r1.72 ar.c
--- ar.c 8 Dec 2010 05:05:30 -0000 1.72
+++ ar.c 8 Mar 2011 20:18:42 -0000
@@ -1186,6 +1186,7 @@ move_members (bfd *arch, char **files_to
{
bfd **after_bfd; /* New entries go after this one */
bfd **current_ptr_ptr; /* cdr pointer into contents */
+ char *tmp = NULL;
for (; *files_to_move; ++files_to_move)
{
@@ -1193,8 +1194,9 @@ move_members (bfd *arch, char **files_to
while (*current_ptr_ptr)
{
bfd *current_ptr = *current_ptr_ptr;
- if (FILENAME_CMP (normalize (*files_to_move, arch),
- current_ptr->filename) == 0)
+ free (tmp);
+ tmp = normalize (*files_to_move, arch);
+ if (FILENAME_CMP (tmp, current_ptr->filename) == 0)
{
/* Move this file to the end of the list - first cut from
where it is. */
@@ -1218,10 +1220,12 @@ move_members (bfd *arch, char **files_to
/* xgettext:c-format */
fatal (_("no entry %s in archive %s!"), *files_to_move, arch->filename);
- next_file:;
+ next_file:
+ ;
}
write_archive (arch);
+ free (tmp);
}
/* Ought to default to replacing in place, but this is existing practice! */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] ar.c (move_members): Plug memory leak.
2011-03-08 20:20 [RFA] ar.c (move_members): Plug memory leak Michael Snyder
@ 2011-03-25 17:14 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2011-03-25 17:14 UTC (permalink / raw)
To: Michael Snyder; +Cc: binutils
Hi Michael,
> 2011-03-08 Michael Snyder<msnyder@vmware.com>
>
> * ar.c (move_members): Plug memory leak.
Approved and applied, with a few casts and type changes to fix compile
time warning messages.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-25 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-08 20:20 [RFA] ar.c (move_members): Plug memory leak Michael Snyder
2011-03-25 17:14 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).