From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14373 invoked by alias); 25 Mar 2011 18:04:24 -0000 Received: (qmail 14346 invoked by uid 22791); 25 Mar 2011 18:04:22 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 18:04:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2PI47Ia013420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Mar 2011 14:04:07 -0400 Received: from [10.36.10.101] (vpn2-10-101.ams2.redhat.com [10.36.10.101]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2PI459c022905; Fri, 25 Mar 2011 14:04:06 -0400 Message-ID: <4D8CD936.8070806@redhat.com> Date: Fri, 25 Mar 2011 18:04:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Pierre Muller CC: "'Kai Tietz'" , "'H.J. Lu'" , "'Binutils'" Subject: Re: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code References: <-8460070221060995487@unknownmsgid> <-6930711422310680743@unknownmsgid> <4D63D49D.90101@redhat.com> <-2339605939192327273@unknownmsgid> <-3886800211494155692@unknownmsgid> <1561346207520594884@unknownmsgid> <5095785081977025060@unknownmsgid> <00d601cbd4f0$c911af10$5b350d30$@muller@ics-cnrs.unistra.fr> <4D8CB1F5.6020108@redhat.com> <000a01cbeb04$0c0e6e60$242b4b20$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000a01cbeb04$0c0e6e60$242b4b20$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00463.txt.bz2 Hi Pierre, > I have no real idea if those three cases are > really variables that can reach up to values that > do not fit in 4-bytes but it can not really hurt, can it? Agreed. > ChangeLog entry: > 2011-03-25 Pierre Muller > > * dwarf.c (decode_location_expression): Use dwarf_vmatoa > function to display DW_OP_addr OP. > (process_debug_info): Use dwarf_vma type for local variables > length and type_offset. Approved and applied - note: there were a couple of places where the "length" variable was being displayed in a printf() style output, so I updated these to use the dwarf_vmatoa() function as well. Cheers Nick