Re: gas -Werror compilation break [Re: [patch ld bfd gas]: Handle linkonce for cfi generated debug_frame and eh_frame data]

[Dave Korn <dave.korn.cygwin@gmail.com>]

On 05/05/2011 14:21, Alan Modra wrote:
> On Thu, May 05, 2011 at 06:14:54PM +0930, Alan Modra wrote:
>> I'll be committing the following instead, which I wrote a couple of
>> days ago but didn't get around to installing, or even writing a
>> changelog.
> 
> Now committed with this ChangeLog entry.
> 
> 	* dw2gencfi.c (SUPPORT_FRAME_LINKONCE): Define.  Use throughout
> 	file to conditionally compile code added 2011-04-26.
> 	(cfi_change_reg_numbers): Add ATTRIBUTE_UNUSED on params only used
> 	when SUPPORT_FRAME_LINKONCE.
> 	(get_cfi_seg): Likewise.  Reintroduce old code for when not
> 	SUPPORT_FRAME_LINKONCE.
> 	(cfi_finish): Move get_cfi_seg calls out of loop when not
> 	SUPPORT_FRAME_LINKONCE.  Avoid unused var warning.
> 

  Hmm, still getting this:

> /n/10/davek/binutils/src.clean/gas/dw2gencfi.c: In function 'cfi_finish':
> /n/10/davek/binutils/src.clean/gas/dw2gencfi.c:1903:17: error: variable 'ccseg' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> 
> make[4]: *** [dw2gencfi.o] Error 1

... on x86_64-linux with rev 1.53 of dw2gencfi.c.

    cheers,
      DaveK