From: Dave Korn <dave.korn.cygwin@gmail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH,plugins,head+2.21] Fix pr12365 on COFF.
Date: Sat, 07 May 2011 14:29:00 -0000 [thread overview]
Message-ID: <4DC55738.2010208@gmail.com> (raw)
In-Reply-To: <20110507061306.GQ7018@bubble.grove.modra.org>
On 07/05/2011 07:13, Alan Modra wrote:
> On Fri, May 06, 2011 at 06:37:05PM +0100, Dave Korn wrote:
>> Tested on i686-pc-cygwin, fixes PR12365 and current failures in the
>> ld-plugin tests and HJ's lto tests except for the ones that rely on mixed IR
>> and non-IR relocatable links.
>>
>> OK for head and backport to branch in a couple of days time?
>
> OK.
>
>> + /* Complain if definition comes from a discarded section. */
>> + if (ps->flags & SEC_EXCLUDE)
>
> Strictly speaking this only tests for one class of discarded sections.
> I'm happy with the test, just the comment is a little misleading.
Reworded to "an excluded section", and applied after remembering to
reference the PR in the changelogs.
cheers,
DaveK
prev parent reply other threads:[~2011-05-07 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 17:37 Dave Korn
2011-05-07 6:13 ` Alan Modra
2011-05-07 14:29 ` Dave Korn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC55738.2010208@gmail.com \
--to=dave.korn.cygwin@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).