From: Bernd Schmidt <bernds@codesourcery.com>
To: binutils@sources.redhat.com
Cc: Paul Brook <paul@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Fix ld testcases on c6x
Date: Wed, 11 May 2011 11:11:00 -0000 [thread overview]
Message-ID: <4DCA6E9F.3030409@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
This corrects some ld testsuite failures which I failed to spot before
checking in my C6X -mpic patch. OK?
I'm also seeing
Running /local/src/egcs/src/ld/testsuite/ld-tic6x/tic6x.exp ...
FAIL: ld-tic6x/unwind-1
FAIL: ld-tic6x/unwind-2
FAIL: ld-tic6x/unwind-3
FAIL: ld-tic6x/unwind-4
ERROR: dump program unspecified in
/local/src/egcs/src/ld/testsuite/ld-tic6x/unwind-6.d
Paul?
Bernd
[-- Attachment #2: mpic-ts.diff --]
[-- Type: text/plain, Size: 2283 bytes --]
* ld-elf/frame.exp: Use -mpic -mpid=near assembler options for tic6x.
* ld-elf/exclude.exp: Likewise.
Index: ld/testsuite/ld-elf/frame.exp
===================================================================
--- ld/testsuite/ld-elf/frame.exp (revision 316201)
+++ ld/testsuite/ld-elf/frame.exp (working copy)
@@ -44,14 +44,20 @@ if { [istarget "hppa64-*-*"] || [istarge
return
}
+# This target requires extra as options when building code for shared
+# libraries.
+if { [istarget "tic6x-*-*"] } {
+ set as_opt "-mpic -mpid=near"
+}
+
set test1 "read-only .eh_frame section"
set test2 "read-only .gcc_except_table section"
global as
global ld
-if { ![ld_assemble $as $srcdir/$subdir/tbss.s tmpdir/tbss.o ]
- || ![ld_assemble $as $srcdir/$subdir/frame.s tmpdir/frame.o] } {
+if { ![ld_assemble $as "$as_opt $srcdir/$subdir/tbss.s" tmpdir/tbss.o ]
+ || ![ld_assemble $as "$as_opt $srcdir/$subdir/frame.s" tmpdir/frame.o] } {
unresolved "$test1"
return
}
@@ -66,7 +72,7 @@ if { [ld_simple_link $ld tmpdir/frame.so
}
}
-if ![ld_assemble $as $srcdir/$subdir/table.s tmpdir/table.o ] {
+if ![ld_assemble $as "$as_opt $srcdir/$subdir/table.s" tmpdir/table.o ] {
unresolved "$test2"
return
}
Index: ld/testsuite/ld-elf/exclude.exp
===================================================================
--- ld/testsuite/ld-elf/exclude.exp (revision 316201)
+++ ld/testsuite/ld-elf/exclude.exp (working copy)
@@ -31,6 +31,12 @@ if { [istarget "mcore-*-*"] } {
return
}
+# This target requires extra as options when building code for shared
+# libraries.
+if { [istarget "tic6x-*-*"] } {
+ set as_opt "-mpic -mpid=near"
+}
+
global ar
global as
global ld
@@ -47,8 +53,8 @@ set test7 "ld exclude symbols from archi
set test8 "ld exclude symbols from archive - --exclude-libs foo,libexclude.a"
set test9 "ld don't exclude symbols from archive - --exclude-libs foo:bar"
-if { ![ld_assemble $as $srcdir/$subdir/exclude1.s tmpdir/exclude1.o ]
- || ![ld_assemble $as $srcdir/$subdir/exclude2.s tmpdir/exclude2.o] } {
+if { ![ld_assemble $as "$as_opt $srcdir/$subdir/exclude1.s" tmpdir/exclude1.o ]
+ || ![ld_assemble $as "$as_opt $srcdir/$subdir/exclude2.s" tmpdir/exclude2.o] } {
unresolved $test1
return
}
next reply other threads:[~2011-05-11 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 11:11 Bernd Schmidt [this message]
2011-05-11 11:20 ` Joseph S. Myers
2011-05-11 11:56 ` Alan Modra
2011-05-11 12:31 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA6E9F.3030409@codesourcery.com \
--to=bernds@codesourcery.com \
--cc=binutils@sources.redhat.com \
--cc=joseph@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).