From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-72502-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 6476 invoked by alias); 28 Jul 2011 16:39:29 -0000
Received: (qmail 6386 invoked by uid 22791); 28 Jul 2011 16:39:28 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 16:39:12 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SGd3oi014570	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 28 Jul 2011 12:39:03 -0400
Received: from [10.36.7.163] (vpn1-7-163.ams2.redhat.com [10.36.7.163])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6SGcqBE004924;	Thu, 28 Jul 2011 12:38:58 -0400
Message-ID: <4E3190E1.3020904@redhat.com>
Date: Thu, 28 Jul 2011 16:42:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11
MIME-Version: 1.0
To: Nathan Sidwell <nathan@codesourcery.com>
CC: Andreas Schwab <schwab@redhat.com>, binutils <binutils@sourceware.org>
Subject: Re: [GAS] fix crash on erroneous directive
References: <4E2FF98E.4040608@codesourcery.com> <m3vcungb3e.fsf@hase.home>	<4E3005A0.9020902@codesourcery.com> <m3mxfzg6pv.fsf@hase.home> <4E3128D2.8020205@codesourcery.com>
In-Reply-To: <4E3128D2.8020205@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00253.txt.bz2

Hi Nathan,

>> You could define a symbol and then use to the right nop depending on the
>> symbol's value.
>
> like this?

Yes - although it turns out that there are other targets that have nops 
that take arguments, do not have a nop instruction at all, or do not 
generate dwarf2 debug information, so the test as you had it needed a 
little more tweaking.  I have taken care of this however, and checked 
the result in.

Cheers
   Nick