From: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
To: Nick Clifton <nickc@redhat.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [RFA/ARM]: Patch to workaround ARM1176 BLX (immediate) Thumb to ARM issue
Date: Thu, 28 Jul 2011 21:33:00 -0000 [thread overview]
Message-ID: <4E319514.9050102@arm.com> (raw)
In-Reply-To: <4E316C2B.6060906@redhat.com>
On 28/07/11 15:03, Nick Clifton wrote:
> Hi Matthew,
>
>> * When the option is on the linker will only use BLX if the target
>> architecture (derived from the object files) is v6T2, v7, or
>> greater.
>
> This does not seem right to me. The erratum only applies to the
> ARM1176JZ-S and ARM1176JZF-S processors and only to Thumb BLX
> instructions. Disabling the use of BLX in ARM mode or for pre-ARM11
> cores will generate needlessly larger code.
The argument for doing it this way is that there are systems where code
is built for architecture ARMv5TE (for example) yet the devices the code
is run on is an ARM1176.
The aim of having the fix on by default for architectures before ARMv6T2
is to catch these cases.
I was also looking for the least disruptive fix to the linker code paths
so that the changes made would be easily tested.
> Also when you check the Tag_CPU_arch value, please use the enum names,
> not the integer values.
Noted - a patch will be forthcoming with updates following your comments
and Joseph Myers'.
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer, PD Software - Tools, ARM Ltd
next prev parent reply other threads:[~2011-07-28 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 16:29 Matthew Gretton-Dann
2011-07-27 16:44 ` Joseph S. Myers
2011-07-28 16:41 ` Nick Clifton
2011-07-28 21:33 ` Matthew Gretton-Dann [this message]
2011-07-29 13:34 ` Matthew Gretton-Dann
2011-08-08 9:52 ` [PING] " Matthew Gretton-Dann
2011-08-09 12:17 ` Nick Clifton
2011-08-09 13:15 ` Matthew Gretton-Dann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E319514.9050102@arm.com \
--to=matthew.gretton-dann@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).