From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31839 invoked by alias); 9 Aug 2011 12:17:23 -0000 Received: (qmail 31824 invoked by uid 22791); 9 Aug 2011 12:17:21 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 12:16:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p79CGEs5013400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Aug 2011 08:16:15 -0400 Received: from [10.36.5.36] (vpn1-5-36.ams2.redhat.com [10.36.5.36]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p79CGCWt025937; Tue, 9 Aug 2011 08:16:13 -0400 Message-ID: <4E412562.1090901@redhat.com> Date: Tue, 09 Aug 2011 12:17:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: Matthew Gretton-Dann CC: "binutils@sourceware.org" , Richard Earnshaw , "Joseph S. Myers" Subject: Re: [PING] [RFA/ARM]: Patch to workaround ARM1176 BLX (immediate) Thumb to ARM issue References: <4E3037DD.7030606@arm.com> <4E316C2B.6060906@redhat.com> <4E319514.9050102@arm.com> <4E327D15.9070804@arm.com> <4E3FB1C1.4020201@arm.com> In-Reply-To: <4E3FB1C1.4020201@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00080.txt.bz2 Hi Matthew, > Please can someone review this patch? Sorry for the delay. >> bfd/ChangeLog: >> 2011-07-29 Matthew Gretton-Dann >> >> * bfd-in.h (bfd_elf32_arm_set_target_relocs): Update prototype. >> * bfd-in2.h (bfd_elf32_arm_set_target_relocs): Likewise. >> * elf32-arm.c (elf32_arm_link_hash_table): New field. >> (elf232_arm_link_hash_table_create): Initialise new field. >> (check_use_blx): Change test depending on fix_arm1176. >> (bfd_elf32_arm_set_target_relocs): Set fix_arm1176 from >> command line options. >> >> ld/ChangeLog: >> 2011-07-29 Matthew Gretton-Dann >> >> * emultempl/armelf.em (fix_arm1176): New variable. >> (arm_elf_create_output_section_statements): Pass >> fix_arm1176 option to bfd backend. >> (OPTION_FIX_ARM1176): New define. >> (OPTION_NO_FIX_ARM1176): Likewise. >> (PARSE_AND_LIST_LONGOPTS): Add new command line options. >> (PARSE_AND_LIST_OPTIONS): Likewise. >> (PARSE_AND_LIST_ARGS_CASES): Likewise. >> * ld.texinfo: Document new command line options. >> >> ld/testsuite/ChangeLog: >> 2011-07-29 Matthew Gretton-Dann >> >> * ld-arm/arm-elf.exp (armelftests): Update for new command-line >> options. >> (armeabitests): Update for new command-line options, and add >> new test cases. >> * ld-arm/fix-arm1176.s: Add test case. >> * ld-arm/fix-arm1176-off.d: Likewise. >> * ld-arm/fix-arm1176-on.d: Likewise. Approved - please apply. But ... >> +@cindex ARM1176 erratum workaround >> +@kindex --fix-arm1176 >> +@kindex --no-fix-arm1176 >> +The @samp{--fix-arm1176} switch enables a link-time workaround for an >> erratum >> +in certain ARM1176 processors. The workaround is enabled by default >> if you >> +are targetting ARM v6 (excluding ARM v6T2) or earlier. It can be >> disabled >> +unconditionally by specifying @samp{--no-fix-arm1176}. >> + >> +Please contact ARM for further details. It would be nice to include the URL to ARM's Erratum here. Cheers Nick