* [PATCH] Add TILEPro and TILE-Gx port maintainer.
@ 2011-10-28 7:46 Walter Lee
2011-10-28 13:04 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: Walter Lee @ 2011-10-28 7:46 UTC (permalink / raw)
To: binutils
This patch adds myself as TILEPro and TILE-Gx port maintainer. Ok to
commit?
binuitls/ChangeLog
2011-10-28 Walter Lee <walt@tilera.com>
* MAINTAINERS: Add myself as TILEPro and TILE-Gx port maintainer.
Index: binutils/MAINTAINERS
===================================================================
RCS file: /cvs/src/src/binutils/MAINTAINERS,v
retrieving revision 1.139
diff -u -p -r1.139 MAINTAINERS
--- binutils/MAINTAINERS 27 Oct 2011 14:13:24 -0000 1.139
+++ binutils/MAINTAINERS 28 Oct 2011 06:30:50 -0000
@@ -118,6 +118,8 @@ responsibility among the other maintaine
TIC4X Svein Seldal <svein@dev.seldal.com>
TIC54X Timothy Wall <twall@alum.mit.edu>
TIC6X Joseph Myers <joseph@codesourcery.com>
+ TILE-Gx Walter Lee <walt@tilera.com>
+ TILEPro Walter Lee <walt@tilera.com>
VAX Matt Thomas <matt@netbsd.org>
VAX Jan-Benedict Glaw <jbglaw@lug-owl.de>
VMS Tristan Gingold <gingold@adacore.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add TILEPro and TILE-Gx port maintainer.
2011-10-28 7:46 [PATCH] Add TILEPro and TILE-Gx port maintainer Walter Lee
@ 2011-10-28 13:04 ` Nick Clifton
0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2011-10-28 13:04 UTC (permalink / raw)
To: Walter Lee; +Cc: binutils
Hi Walter,
> binuitls/ChangeLog
> 2011-10-28 Walter Lee<walt@tilera.com>
>
> * MAINTAINERS: Add myself as TILEPro and TILE-Gx port maintainer.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add TILEPro and TILE-Gx port maintainer.
2011-10-28 7:47 Walter Lee
@ 2011-10-28 13:06 ` Nick Clifton
0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2011-10-28 13:06 UTC (permalink / raw)
To: Walter Lee; +Cc: binutils
Hi Walter,
> OK to commit?
Yes.
> Since I'm the maintainers for these ports can I
> commit without approval ahead of time?
For TILEPro specific changes like this one: yes. Please do send the
patch to the mailing list though, along with an explanation of what is
happening, so that other people can follow the port.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Add TILEPro and TILE-Gx port maintainer.
@ 2011-10-28 7:47 Walter Lee
2011-10-28 13:06 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: Walter Lee @ 2011-10-28 7:47 UTC (permalink / raw)
To: binutils
This patch fixes the TILE-Gx/TILEPro port of gas to deal with
relocations of aliases, and is needed to compile glibc and the latest
gcc. OK to commit? Since I'm the maintainers for these ports can I
commit without approval ahead of time?
gas/ChangeLog
2011-10-28 Walter Lee <walt@tilera.com>
* config/tc-tilegx.c (emit_tilegx_instruction) Handle
relocations of aliases.
* config/tc-tilepro.c: (emit_tilepro_instruction) Likewise.
Index: gas/config/tc-tilegx.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-tilegx.c,v
retrieving revision 1.1
diff -u -p -r1.1 tc-tilegx.c
--- gas/config/tc-tilegx.c 13 Jun 2011 15:18:48 -0000 1.1
+++ gas/config/tc-tilegx.c 28 Oct 2011 06:30:50 -0000
@@ -691,15 +691,19 @@ emit_tilegx_instruction (tilegx_bundle_b
if (operand_exp->X_add_symbol->sy_value.X_md)
{
- if (require_symbol)
- {
- as_bad (_("Operator may only be applied to symbols."));
- }
-
/* HACK: We used X_md to mark this symbol as a fake wrapper
around a real expression. To unwrap it, we just grab its
value here. */
operand_exp = &operand_exp->X_add_symbol->sy_value;
+
+ if (require_symbol)
+ {
+ /* Look at the expression, and reject it if it's not a
+ plain symbol. */
+ if (operand_exp->X_op != O_symbol
+ || operand_exp->X_add_number != 0)
+ as_bad (_("Operator may only be applied to symbols."));
+ }
}
else
{
Index: gas/config/tc-tilepro.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-tilepro.c,v
retrieving revision 1.1
diff -u -p -r1.1 tc-tilepro.c
--- gas/config/tc-tilepro.c 13 Jun 2011 15:18:48 -0000 1.1
+++ gas/config/tc-tilepro.c 28 Oct 2011 06:30:50 -0000
@@ -560,15 +560,19 @@ emit_tilepro_instruction (tilepro_bundle
if (operand_exp->X_add_symbol->sy_value.X_md)
{
- if (require_symbol)
- {
- as_bad (_("Operator may only be applied to symbols."));
- }
-
/* HACK: We used X_md to mark this symbol as a fake wrapper
around a real expression. To unwrap it, we just grab its
value here. */
operand_exp = &operand_exp->X_add_symbol->sy_value;
+
+ if (require_symbol)
+ {
+ /* Look at the expression, and reject it if it's not a
+ plain symbol. */
+ if (operand_exp->X_op != O_symbol
+ || operand_exp->X_add_number != 0)
+ as_bad (_("Operator may only be applied to symbols."));
+ }
}
else
{
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-28 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-28 7:46 [PATCH] Add TILEPro and TILE-Gx port maintainer Walter Lee
2011-10-28 13:04 ` Nick Clifton
2011-10-28 7:47 Walter Lee
2011-10-28 13:06 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).