From: Michael Eager <eager@eagerm.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: binutils Development <binutils@sourceware.org>
Subject: Re: [Patch]: Improve handling of DW_LNE_define_file
Date: Thu, 19 Jan 2012 13:32:00 -0000 [thread overview]
Message-ID: <4F181B62.6000102@eagerm.com> (raw)
In-Reply-To: <FB3BD091-6416-4F4D-B59C-B6A8B00362D2@adacore.com>
On 01/12/2012 04:05 AM, Tristan Gingold wrote:
> index a775818..08f472f 100644
> --- a/binutils/dwarf.c
> +++ b/binutils/dwarf.c
> @@ -288,7 +289,11 @@ process_extended_line_op (unsigned char *data, int is_stmt)
> printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,& bytes_read, 0)));
> data += bytes_read;
> printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,& bytes_read, 0)));
> - printf ("%s\n\n", name);
> + data += bytes_read;
> + printf ("%s", name);
> + if (data - orig_data != len)
This should be
if ((unsigned int) (data - orig_data) != len)
or change len to "int".
I prefer changing len. I can check in obvious patch.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2012-01-19 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 12:05 Tristan Gingold
2012-01-16 22:16 ` Alan Modra
2012-01-19 11:35 ` Tristan Gingold
2012-01-19 13:32 ` Michael Eager [this message]
2012-01-19 13:53 ` Tristan Gingold
2012-01-19 13:59 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F181B62.6000102@eagerm.com \
--to=eager@eagerm.com \
--cc=binutils@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).