From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4660 invoked by alias); 19 Jan 2012 13:32:33 -0000 Received: (qmail 4652 invoked by uid 22791); 19 Jan 2012 13:32:32 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a51.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 13:32:20 +0000 Received: from homiemail-a51.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a51.g.dreamhost.com (Postfix) with ESMTP id C951C2E805C; Thu, 19 Jan 2012 05:32:19 -0800 (PST) Received: from redwood.eagercon.com (c-76-102-3-160.hsd1.ca.comcast.net [76.102.3.160]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a51.g.dreamhost.com (Postfix) with ESMTPSA id A15912E8058; Thu, 19 Jan 2012 05:32:19 -0800 (PST) Message-ID: <4F181B62.6000102@eagerm.com> Date: Thu, 19 Jan 2012 13:32:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Tristan Gingold CC: binutils Development Subject: Re: [Patch]: Improve handling of DW_LNE_define_file References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00202.txt.bz2 On 01/12/2012 04:05 AM, Tristan Gingold wrote: > index a775818..08f472f 100644 > --- a/binutils/dwarf.c > +++ b/binutils/dwarf.c > @@ -288,7 +289,11 @@ process_extended_line_op (unsigned char *data, int is_stmt) > printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,& bytes_read, 0))); > data += bytes_read; > printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,& bytes_read, 0))); > - printf ("%s\n\n", name); > + data += bytes_read; > + printf ("%s", name); > + if (data - orig_data != len) This should be if ((unsigned int) (data - orig_data) != len) or change len to "int". I prefer changing len. I can check in obvious patch. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077