From: John Marino <binutils@marino.st>
To: binutils@sourceware.org
Subject: suggestion for gold's testsuite makefile (initpri2 LDFLAGS)
Date: Mon, 06 Feb 2012 12:07:00 -0000 [thread overview]
Message-ID: <4F2FC254.4080800@marino.st> (raw)
The initpri2 test can only pass if the --ctors-in-init-array option is
enabled. With a default build, Gold enables this option by default.
Still, the testsuite should not assume the option is enabled, it should
explicitly set it.
Suggestion to change line 2280 of Makefile.in FROM:
@GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/
TO
@GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ -Wl,--ctors-in-init-array
As background, the BSDs need to build Gold with a modified options.h
file to set --no-ctors-in-init-array as the default. I'm in the
process of getting DragonFly BSD to support DT_INIT_ARRAY and friends
and this test was failing even though the crt1.o had been properly
modified to support it. Making this change either has no effect or
it means the difference between a pass or fail on a capable system
with a non-standard ctors-in-init-array default.
John
next reply other threads:[~2012-02-06 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 12:07 John Marino [this message]
2012-02-15 9:28 ` John Marino
2012-02-16 2:15 ` Ian Lance Taylor
2012-02-16 19:39 ` Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2FC254.4080800@marino.st \
--to=binutils@marino.st \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).