From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21614 invoked by alias); 6 Feb 2012 12:07:25 -0000 Received: (qmail 21585 invoked by uid 22791); 6 Feb 2012 12:07:22 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.synsport.com (HELO shepard.synsport.net) (208.69.230.148) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 12:06:49 +0000 Received: from [192.168.0.219] (atoulouse-256-1-48-233.w90-38.abo.wanadoo.fr [90.38.239.233]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id AFA2843B4A for ; Mon, 6 Feb 2012 06:06:47 -0600 (CST) Message-ID: <4F2FC254.4080800@marino.st> Date: Mon, 06 Feb 2012 12:07:00 -0000 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: binutils@sourceware.org Subject: suggestion for gold's testsuite makefile (initpri2 LDFLAGS) Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00044.txt.bz2 The initpri2 test can only pass if the --ctors-in-init-array option is enabled. With a default build, Gold enables this option by default. Still, the testsuite should not assume the option is enabled, it should explicitly set it. Suggestion to change line 2280 of Makefile.in FROM: @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ TO @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ -Wl,--ctors-in-init-array As background, the BSDs need to build Gold with a modified options.h file to set --no-ctors-in-init-array as the default. I'm in the process of getting DragonFly BSD to support DT_INIT_ARRAY and friends and this test was failing even though the crt1.o had been properly modified to support it. Making this change either has no effect or it means the difference between a pass or fail on a capable system with a non-standard ctors-in-init-array default. John