* [patch ld]: Fix duplicates in export-table due missing set of is_ident.
@ 2012-02-13 12:41 Kai Tietz
2012-02-13 12:49 ` Kai Tietz
0 siblings, 1 reply; 3+ messages in thread
From: Kai Tietz @ 2012-02-13 12:41 UTC (permalink / raw)
To: Binutils
Hi,
this patch avoids double-entries for first or last element search. We missed
to set for identity is_indent in those cases.
ChangeLog
2012-02-13 Kai Tietz <ktietz@redhat.com>
* deffilep.y (find_export_in_list): Set is_indent for
first or last element, if identical.
Tested for i686-w64-mingw32, and x86_64-w64-mingw32. Ok for apply?
Regards,
Kai
Index: deffilep.y
===================================================================
RCS file: /cvs/src/src/ld/deffilep.y,v
retrieving revision 1.37
diff -r1.37 deffilep.y
625c625,629
< return 0;
---
> {
> if (!e)
> *is_ident = 1;
> return 0;
> }
631c635,639
< return max - 1;
---
> {
> if (!e)
> *is_ident = 1;
> return max - 1;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch ld]: Fix duplicates in export-table due missing set of is_ident.
2012-02-13 12:41 [patch ld]: Fix duplicates in export-table due missing set of is_ident Kai Tietz
@ 2012-02-13 12:49 ` Kai Tietz
2012-02-13 16:35 ` nick clifton
0 siblings, 1 reply; 3+ messages in thread
From: Kai Tietz @ 2012-02-13 12:49 UTC (permalink / raw)
To: Binutils; +Cc: Nick Clifton
Hi,
I missed here the import-case, so I resent. This patch avoids
double-entries for first or last element search. We missed
to set for identity is_indent in those cases.
ChangeLog
2012-02-13 Kai Tietz <ktietz@redhat.com>
* deffilep.y (find_export_in_list): Set is_indent for
first or last element, if identical.
(find_import_in_list): Likewise.
ested for i686-w64-mingw32, and x86_64-w64-mingw32. Ok for apply?
Regards,
Kai
Index: deffilep.y
===================================================================
RCS file: /cvs/src/src/ld/deffilep.y,v
retrieving revision 1.37
diff -r1.37 deffilep.y
625c625,629
< return 0;
---
> {
> if (!e)
> *is_ident = 1;
> return 0;
> }
631c635,639
< return max - 1;
---
> {
> if (!e)
> *is_ident = 1;
> return max - 1;
> }
760c768,772
< return 0;
---
> {
> if (!e)
> *is_ident = 1;
> return 0;
> }
766c778,782
< return max - 1;
---
> {
> if (!e)
> *is_ident = 1;
> return max - 1;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch ld]: Fix duplicates in export-table due missing set of is_ident.
2012-02-13 12:49 ` Kai Tietz
@ 2012-02-13 16:35 ` nick clifton
0 siblings, 0 replies; 3+ messages in thread
From: nick clifton @ 2012-02-13 16:35 UTC (permalink / raw)
To: Kai Tietz; +Cc: Binutils
Hi Kai,
> 2012-02-13 Kai Tietz <ktietz@redhat.com>
>
> * deffilep.y (find_export_in_list): Set is_indent for
> first or last element, if identical.
> (find_import_in_list): Likewise.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-13 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-13 12:41 [patch ld]: Fix duplicates in export-table due missing set of is_ident Kai Tietz
2012-02-13 12:49 ` Kai Tietz
2012-02-13 16:35 ` nick clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).