From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13708 invoked by alias); 15 Feb 2012 09:28:22 -0000 Received: (qmail 13699 invoked by uid 22791); 15 Feb 2012 09:28:21 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from mail.synsport.com (HELO shepard.synsport.net) (208.69.230.148) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Feb 2012 09:27:48 +0000 Received: from [10.31.9.224] (unknown [213.225.137.129]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 7880243B4A for ; Wed, 15 Feb 2012 03:27:47 -0600 (CST) Message-ID: <4F3B7A92.9010100@marino.st> Date: Wed, 15 Feb 2012 09:28:00 -0000 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: binutils@sourceware.org Subject: Re: suggestion for gold's testsuite makefile (initpri2 LDFLAGS) References: <4F2FC254.4080800@marino.st> In-Reply-To: <4F2FC254.4080800@marino.st> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00122.txt.bz2 On 2/6/2012 13:06, John Marino wrote: > The initpri2 test can only pass if the --ctors-in-init-array option is > enabled. With a default build, Gold enables this option by default. > Still, the testsuite should not assume the option is enabled, it should > explicitly set it. > > Suggestion to change line 2280 of Makefile.in FROM: > @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ > TO > @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ -Wl,--ctors-in-init-array > > > As background, the BSDs need to build Gold with a modified options.h > file to set --no-ctors-in-init-array as the default. I'm in the > process of getting DragonFly BSD to support DT_INIT_ARRAY and friends > and this test was failing even though the crt1.o had been properly > modified to support it. Making this change either has no effect or > it means the difference between a pass or fail on a capable system > with a non-standard ctors-in-init-array default. > > John I don't think anybody responded to this post from last week, but I don't want it to fall between the cracks. Is it a good idea to modify the gold testsuite makefile with this change? John