* [PING, ARM] fix ADR encoding
@ 2012-07-06 1:44 Sandra Loosemore
2012-07-06 14:30 ` Richard Earnshaw
2012-07-15 19:37 ` [PING**2, " Sandra Loosemore
0 siblings, 2 replies; 5+ messages in thread
From: Sandra Loosemore @ 2012-07-06 1:44 UTC (permalink / raw)
To: binutils
I cannot find any evidence that this patch was ever reviewed:
http://sourceware.org/ml/binutils/2010-09/msg00466.html
I've just checked that the bug this patch fixes is still present, and
the patch still fixes it. OK to check it in? (Jie is no longer at
CodeSourcery/Mentor, I'm following up on some patches of his.)
-Sandra
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING, ARM] fix ADR encoding
2012-07-06 1:44 [PING, ARM] fix ADR encoding Sandra Loosemore
@ 2012-07-06 14:30 ` Richard Earnshaw
2012-07-06 15:05 ` Sandra Loosemore
2012-07-15 19:37 ` [PING**2, " Sandra Loosemore
1 sibling, 1 reply; 5+ messages in thread
From: Richard Earnshaw @ 2012-07-06 14:30 UTC (permalink / raw)
To: Sandra Loosemore; +Cc: binutils
On 06/07/12 02:44, Sandra Loosemore wrote:
> I cannot find any evidence that this patch was ever reviewed:
>
> http://sourceware.org/ml/binutils/2010-09/msg00466.html
>
> I've just checked that the bug this patch fixes is still present, and
> the patch still fixes it. OK to check it in? (Jie is no longer at
> CodeSourcery/Mentor, I'm following up on some patches of his.)
>
> -Sandra
>
>
>
>
Could you check that this does the correct thing for
ADR r0, .+4
Which should also generate encoding A2
R.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING, ARM] fix ADR encoding
2012-07-06 14:30 ` Richard Earnshaw
@ 2012-07-06 15:05 ` Sandra Loosemore
0 siblings, 0 replies; 5+ messages in thread
From: Sandra Loosemore @ 2012-07-06 15:05 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: binutils
On 07/06/2012 08:30 AM, Richard Earnshaw wrote:
> Could you check that this does the correct thing for
>
> ADR r0, .+4
>
> Which should also generate encoding A2
Yes, it does. The above disassembles as
00000000 <foo> e24f0004 sub r0, pc, #4
which matches the A2 pattern:
1110 00 1 0010 0 1111 0000 000000000100
-Sandra
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING**2, ARM] fix ADR encoding
2012-07-06 1:44 [PING, ARM] fix ADR encoding Sandra Loosemore
2012-07-06 14:30 ` Richard Earnshaw
@ 2012-07-15 19:37 ` Sandra Loosemore
2012-07-24 7:45 ` nick clifton
1 sibling, 1 reply; 5+ messages in thread
From: Sandra Loosemore @ 2012-07-15 19:37 UTC (permalink / raw)
To: binutils
On 07/05/2012 07:44 PM, Sandra Loosemore wrote:
> I cannot find any evidence that this patch was ever reviewed:
>
> http://sourceware.org/ml/binutils/2010-09/msg00466.html
>
> I've just checked that the bug this patch fixes is still present, and
> the patch still fixes it. OK to check it in? (Jie is no longer at
> CodeSourcery/Mentor, I'm following up on some patches of his.)
Ping again?
-Sandra
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING**2, ARM] fix ADR encoding
2012-07-15 19:37 ` [PING**2, " Sandra Loosemore
@ 2012-07-24 7:45 ` nick clifton
0 siblings, 0 replies; 5+ messages in thread
From: nick clifton @ 2012-07-24 7:45 UTC (permalink / raw)
To: Sandra Loosemore; +Cc: binutils
Hi Sandra,
> Ping again?
oops - sorry.
> * config/tc-arm.c (md_apply_fix): Use encoding A2 of ADR
> if offset is negative.
>
> testsuite/
> * gas/arm/adr.d: New test.
> * gas/arm/adr.s: New test.
Patch approved, please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-24 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 1:44 [PING, ARM] fix ADR encoding Sandra Loosemore
2012-07-06 14:30 ` Richard Earnshaw
2012-07-06 15:05 ` Sandra Loosemore
2012-07-15 19:37 ` [PING**2, " Sandra Loosemore
2012-07-24 7:45 ` nick clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).