From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by sourceware.org (Postfix) with ESMTPS id 149353858D20 for ; Fri, 28 Oct 2022 10:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 149353858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZnyiYjRxcmX4e6KTGY3ElKksjU4uYx2kCGWtxmV0FButuzuLlPokWfcDJlOf5a9lmHKYlNCg7yh7VQoz4UaITtyjkRGqwZpvzjyzYOuKOUPux7HujNqlbjNb3p2LQvgfekpM4Y9Zm6+afZTKHtIg1Bc4PncS5IlREXyw3Oin5sbobqeFm7BY6TV4Yu4RWJQxt++DK45QjyKUwalQM3Z9oQjVgpRMhaC5hEsFnIg/WpFc1in5/ORxok0TDgvma7QeIqi1h/oLa94yijbicvozdK81IT3p9m9iz3ErarNXK+VozACCr3NAGpJTOZ2T9xQuVpD8agX8d0EiKx7Yv38+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FCr167RmmKbCvjZyfrNRbiAQoWDLjIaoFydF3MPJauE=; b=fDdJzH9dnj9g5Y7F5nUX9OlwfGhpmHZaiZ8Wza0ISGrwqYSHf2ozWHIClhaeFeWHdOAlIcEM++XIlLP7zGrD3T/hVnR7SkhgqBGbV9hQthzlaAyUn1VHl8nJxa3g1bgIs4yMd1KLgzP8dVaUSMa+/c3XrOAY/oOHj83xEVypQ7qfSyUFqcaJ74P2k5SX5+f8gYKDcMW+hHyI5yxLyVc36M0X45Lax0U7JHwHBFp3knxQmcv5/gNxk0llPvrqvAmbCBxHBwgixq7umJvldA3LOmESrcGGH6rsEirTttXZwhvziJXCXxOPC+LYOsJMvl7V3u49HZ8yRYAdmgDV8DB2OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCr167RmmKbCvjZyfrNRbiAQoWDLjIaoFydF3MPJauE=; b=yj+AiGkblpCuCS2fkF1NhGDC6RXY1IEzmGBUV3fKm68I4rdTTtOaTYac6NF8g9LzA8GNUYguTrIN/Un4B7h8+OPMZTkCb+VfVAqCY0GTnA3v5lDmO4/k62wj0nl8UWEj8OklcfVvQHnG5Kz8H0ANFu1YGMuZfJyZF9LbeKtk/zNEwz/uwp8tJw6FrkJmJygZtj7XCNSILBeZbIQ2FXNFNw3V7QZG/HhgQeGeZgZESAT6lW3X0pca+e8dnCxYS57dgK+5RqiY6AEDvvWreujNFQ8vXIgvZWgYc+TXJOCJLCFHt0zt//ReAjOMcwCIqBkoDP3KO3ZThEIl9gkm+Tvziw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9297.eurprd04.prod.outlook.com (2603:10a6:10:354::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct 2022 10:06:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 10:06:36 +0000 Message-ID: <4a280588-a85b-6ed3-634b-2b9cbc128f86@suse.com> Date: Fri, 28 Oct 2022 12:06:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu From: Jan Beulich Subject: [PATCH] RISC-V/gas: fix build with certain gcc versions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9297:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f474896-6016-4ef5-6f62-08dab8cc1980 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /BS+r6FbCvgX9Po3xJ/ZVrewISunCvSemCSfiedML8unLGTuFPspBaJ7ipAtnqG+nQXDKSaUCjEjlFLj9OxD7JOC8EJCjqyrnkkw/FjdBLCDW6GLQwyJ+VTepYJYoVV6+ICgu6OlnQpRrs0SMiYL37njbJ+vAHjbGFlNGfxvyqEh+buALRkvKN+i0+ccEsZifUMnCdylShwDfGXf/wErgp4SZlt/Y0nbbjbiMsh57+PHIE0rT2A5QmqRYxrkPyuJs+usltnet0aNgtWbd1g65LgOuppBgZ3f3+F9ZFB2L9qHsXAHj6xllsl6uRKgauZYLF0jsZlc78DzYnjOG+2awgynsS7h8tltTV6HVglHSn4XJ/hZhcWXE3nypMWGR/wEK/nDc9jplBRo+6A6Piii2N6XqwzhByDaQBom3SYp6Zl54cSSpn1SRMmvhswS4JW2Qf8na4cMCIy4godoxVeVBqTya+RyOl8daYQ+1ZCFR0b/g8yJRCl1yUhuMOd+e2lc+Tts0O5mnlH1P1cyWoTfyumMYlrGplVT5mZiPoHucnCNjvUTausxdfuLlHV8hD6rjwpfHTvlsvwHmmkEyEkLz2m6WIbiNVLyc5LfSm64l9TPKdCUxmRsT2IJvbhr88l4GHWLZD/Ss1MdsJDrGYFBORud1CxPSH7yzkKPcgSlWt6t87jGVnU+zESJxWqSPQk3mbsvh9jEclimM8EGWJWUv+DpIQ5b3vO8EwQgtibmOoI9ix0DukKTsJajDXsi1L0wzpRAf/QblAIBloble4q+kCUfkHhvzBCXZxkClSJ5t5c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(6506007)(31686004)(2616005)(6512007)(26005)(2906002)(4326008)(54906003)(5660300002)(31696002)(186003)(36756003)(6916009)(6486002)(478600001)(66556008)(66946007)(316002)(66476007)(8676002)(41300700001)(8936002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3IzZGFwU2R2WGRiRzJXbXJhK2phUVZ4alR6WDhqY2N0SVVrbW1hZlRxT0Zt?= =?utf-8?B?UmwzSWpNamltSnZ5RjFNMDBielEvUGJGeXJHajZNeDArakpRWCtsVFJQaUQy?= =?utf-8?B?ejVXT01aaU5MRXlJRnNBZ3FjeGhGM3ZUYVNQR3dQWHBXczZKM0dXNVRxVEdM?= =?utf-8?B?VGhoZFU1YUk3SnZYL1hEeDJXaHpqelBnTFFqRzF4LzNiaFozbEpnNEwxN3lD?= =?utf-8?B?THFwZDBqSHRMWUh4Y3dndUpLVVVoME5BUE9kZWxIejBuV3U3RnNJZUU3Z1Bm?= =?utf-8?B?Y0N3Vlh1Y2huNDdXcDM0Y1lNWHJOZ2djV1BWZTQ4c09XWTgydlNvTnB3TXR1?= =?utf-8?B?dTI0VWJycFpDUzlmd0dPV0g1MjdUaUtSRzgvMVRMcThadzJvajBmM0ZpK1F4?= =?utf-8?B?d3plVEdRY0FjUGtWaHlDb0pXVEQ0eGdIYTh1dlF3VGlJUkJsdXFUd3g3Ulc5?= =?utf-8?B?QnBNVFVMejk5U2xDRWpNWnhidHhkQVJicTlNQkVQVmUrWHBoRnJpMVpETlIr?= =?utf-8?B?TnhPRDZyY0JPMXdNTFlvTExySEhTQlJ4V2FabW1tRlBoSDUvaWcydG5ZYjdv?= =?utf-8?B?MEJNN1c1UWhSMi81Mi9zM2RtZW1WdTBXUnpGMGQ0Q0ZWVEZta3dLeFd4eVFv?= =?utf-8?B?bzFhVDNWQ0tKRG9sd2VPRHEwL1pXZlp4enhmRkMraU9Jc2ZTa3JpQUVNM1dx?= =?utf-8?B?ekt6NUhEUkZidFY1YllWWmszSG1yTVpGWnVtVHdYcmx1VzhJN2tXZnhRMXFu?= =?utf-8?B?YzVMcG1qbEVOMzluMUN0TGkvZjFrbTNlTEs0M3ZaS0RrU0k4VjRjRzlUQnpq?= =?utf-8?B?R2hpYnFrMDlqVzFDaWZxT1lpY2dhUEl6M0grQXFhR1dmTzBKcy9YMm9naFVo?= =?utf-8?B?UTRQc0NTVnRKdkgrMExzNEtXK1pObHdMdG1IaEs1S044ZjhiUzlXbjdtSGFP?= =?utf-8?B?azNHcVRMakh2bytHcWZ2TU5vUjVYOWk1azB2ZlY2V2JuSXJWUjB1TFQrUUUy?= =?utf-8?B?NTRLY01pclBhK2drV0N2ZWlsQ25aNG01bjFsSkJXY01aVXlHYTVmRnRNek9E?= =?utf-8?B?S1JBMzQwdXJadTlvZGUwMFFBR0xNcXJ3K0ZTQ1dwRDAvUGlibzdIclJWbzZm?= =?utf-8?B?Q3pHZzkva1Jwa2dPL05sRHp5QklQamZEV3dIU2RscEZsYjRRelVRamtNbFdP?= =?utf-8?B?MTh6MmVsVTRYVWdHU3haQWZHbGFEZzlyaDY5L2Vjc0dwakMwRGU3dE8yaWth?= =?utf-8?B?c2pnY3F5RGhDT1Z1UUxzdTZVZnFYZ25XMEVQUHVIZVdLRllVeEFkL3V4NFoz?= =?utf-8?B?ZllqVzVoc2Z5ckM4QTNINCtUaVFweHAxZVZYQVVtUDFuMHVLSm96Yi9JWFA5?= =?utf-8?B?Z2s0VGxqWmlLWWt0ZWk0WXZVWExQa0lRVnZjSVRSeEVPeUdKVlZIZEo4ejhV?= =?utf-8?B?MFo0WUhyT0JnY20rUGlkVUgxdUFIbW5Fc1d5Yml1bml3WnR5RkVub0lLdE54?= =?utf-8?B?S0R3aEI3b1Ivb3NtcGJqQkxoVXM5dVowaHlVT1hWQ1d3VTNvNjNULytDRURk?= =?utf-8?B?a3E2bWptM3BDcnhDREFvWGNCNGxtOUtUNy9Yb2pFZ3FPbkV3S2l2aHl3Y3Yx?= =?utf-8?B?dzV0cjFSMUVWMVpwVVU4c1J4NldRa29TNE1Fa3pUZThxa3dTR2FZdi9VOVBJ?= =?utf-8?B?S2p3ZWJFcmJtYlhkTldnNWhaWi92TWV6bWsydjh0SXlmZ1lvSGFaak5MMGdV?= =?utf-8?B?Mnp2RnM0bnJFT3NScFVTa0ZZTjFkRVhueURwcFgzQzh6Q3RFNUpvMjFaVUlW?= =?utf-8?B?NERPRFQycWdldUZFVlRESXRNYW51VHdDbHU1K0Eyak1JMUx5WGRXcW10VnRF?= =?utf-8?B?N1F1SzRWMURrYkpYbmxTMWJqWFpsZndBeFRycEdrU3dDWndMbk5NN3ZLUEM5?= =?utf-8?B?TnM0dnUrcVV1Z3dvbnBvRTRKR2ljbENYNDRNY0dMQzA1cHZJMUFDd1NpaWNF?= =?utf-8?B?K21uenJmdHYxUmhCK00wa2xEalBta3hnWUZYSXhWVHNuOE9jek1PVWt4VXhi?= =?utf-8?B?YnlzSnFzVWZtUXErem8rUjZ3c3A0N2JBUG5LY0NqVVh0UHNNajc5UXRPV1FL?= =?utf-8?Q?HxGoEy1hJCHUuA0xjGEo4YjTD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f474896-6016-4ef5-6f62-08dab8cc1980 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 10:06:36.8283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LdlYZCSCA43qI1VQK1Am5U4oScjRYZX/CRM80/rchjwHwJmIXzPdO910hxC9jgeXmTPbe87mv1Qwhzzp8DFixA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9297 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Some versions of gcc warn by default about shadowed outer-scope declarations. This affects frag_align_code, which is declared in frags.h. Rename the offending function parameter. While there also switch to using true/false at the function call sites. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -549,7 +549,7 @@ make_mapping_symbol (enum riscv_seg_msta void riscv_mapping_state (enum riscv_seg_mstate to_state, int max_chars, - bool frag_align_code) + bool fr_align_code) { enum riscv_seg_mstate from_state = seg_info (now_seg)->tc_segment_info_data.map_state; @@ -574,7 +574,7 @@ riscv_mapping_state (enum riscv_seg_msta } else if (seg_arch_symbol != 0 && to_state == MAP_INSN - && !frag_align_code + && !fr_align_code && strcmp (riscv_rps_as.subset_list->arch_str, S_GET_NAME (seg_arch_symbol) + 2) != 0) { @@ -3540,7 +3540,7 @@ md_assemble (char *str) return; } - riscv_mapping_state (MAP_INSN, 0, 0/* frag_align_code */); + riscv_mapping_state (MAP_INSN, 0, false/* fr_align_code */); const struct riscv_ip_error error = riscv_ip (str, &insn, &imm_expr, &imm_reloc, op_hash); @@ -4219,7 +4219,7 @@ riscv_frag_align_code (int n) fix_new_exp (frag_now, nops - frag_now->fr_literal, 0, &ex, false, BFD_RELOC_RISCV_ALIGN); - riscv_mapping_state (MAP_INSN, worst_case_bytes, 1/* frag_align_code */); + riscv_mapping_state (MAP_INSN, worst_case_bytes, true/* fr_align_code */); /* We need to start a new frag after the alignment which may be removed by the linker, to prevent the assembler from computing static offsets. @@ -4293,10 +4293,10 @@ riscv_init_frag (fragS * fragP, int max_ case rs_fill: case rs_align: case rs_align_test: - riscv_mapping_state (MAP_DATA, max_chars, 0/* frag_align_code */); + riscv_mapping_state (MAP_DATA, max_chars, false/* fr_align_code */); break; case rs_align_code: - riscv_mapping_state (MAP_INSN, max_chars, 1/* frag_align_code */); + riscv_mapping_state (MAP_INSN, max_chars, true/* fr_align_code */); break; default: break; @@ -4570,7 +4570,7 @@ s_riscv_insn (int x ATTRIBUTE_UNUSED) save_c = *input_line_pointer; *input_line_pointer = '\0'; - riscv_mapping_state (MAP_INSN, 0, 0/* frag_align_code */); + riscv_mapping_state (MAP_INSN, 0, false/* fr_align_code */); struct riscv_ip_error error = riscv_ip (str, &insn, &imm_expr, &imm_reloc, insn_type_hash);