From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 688613858D1E for ; Fri, 30 Sep 2022 11:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 688613858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664536129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/fCArxyqlrG/eDpXIeEkTXKkLus9nncppmfQP7EnYM=; b=h0C4STV87+MEfL5adXWiKDD9ayrr1SiASetiPLm/c23MlTJPcxRu68mq9fSJ3dEGzSaa0D RgXUJSJDe+KuVuiOLcofDqSEIAH7U6crKTE5GjM5+X7G2qw24QmOTxXO2mmAaaxPo8befB dYUlIW1A5S6dWcc+Df2UaeI9d9R7lL8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-341-r-VITjtnPwCKc1r-HjxmCg-1; Fri, 30 Sep 2022 07:08:47 -0400 X-MC-Unique: r-VITjtnPwCKc1r-HjxmCg-1 Received: by mail-qt1-f199.google.com with SMTP id fe14-20020a05622a4d4e00b0035cc376b1d5so2714265qtb.4 for ; Fri, 30 Sep 2022 04:08:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=I/fCArxyqlrG/eDpXIeEkTXKkLus9nncppmfQP7EnYM=; b=OowkAFiBnf+jNQMQdh+7pS37NKjSqi881oiPvx8HvJGIsPSLTG8G9CQ1Tej9+RR779 fJ7dwqLQ7ifS/HgNNfvK6rFpFZuT1rpRCGocIQXLYnXktawwVSWRYfq+z518kftxjOCa /6Jk4C7HFnAUm4zPecJRVY3vBkhIxp3bHgmLgG8pKx70UdgtWSmJGgxmqRaJcV23QhSV RRgHFQcu0vpgIdvSqMpUB2CMnPvP3lLdtPgl83GlBCHpyLhaAFZJfhXeAGpQGO5Z+078 XKnbOxnCf751Vovq4ukrYgm63+S7DOdvP3HGzPo/djpZO210N3irysa80dGqH6cT1huG CgbA== X-Gm-Message-State: ACrzQf1Wl7OdZfLg+fnSTb4PpBmsL9pDetL/mO9M1CvxjpDIH45YG/KO b4ffNAQrduuVPU3y33BKFkn2qoe3ctL08c0Nqe8LoRIhh8lRT+tweImwyu8hiNjeUwheA4m7jbf rti6/MQJGwMawbgprwA== X-Received: by 2002:a05:620a:404e:b0:6ce:d80e:7813 with SMTP id i14-20020a05620a404e00b006ced80e7813mr5419107qko.421.1664536127202; Fri, 30 Sep 2022 04:08:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Qlo+b2CKgjnXe3/Su5LS5SmfTBneFzMoxbANXd17v4Dc1fiRiKs3vU2Tmk9MzCFZVD/Ofpg== X-Received: by 2002:a05:620a:404e:b0:6ce:d80e:7813 with SMTP id i14-20020a05620a404e00b006ced80e7813mr5419096qko.421.1664536126999; Fri, 30 Sep 2022 04:08:46 -0700 (PDT) Received: from [192.168.1.18] ([79.123.82.157]) by smtp.gmail.com with ESMTPSA id br12-20020a05622a1e0c00b0035bb732ac93sm1535094qtb.88.2022.09.30.04.08.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 04:08:46 -0700 (PDT) Message-ID: <4a5ea41e-03a4-97ef-bbfe-830e1c01dab3@redhat.com> Date: Fri, 30 Sep 2022 12:08:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: Indu Bhagat , binutils@sourceware.org Cc: weimin.pan@oracle.com References: <20220930000440.1672106-1-indu.bhagat@oracle.com> <20220930000440.1672106-8-indu.bhagat@oracle.com> From: Nick Clifton Subject: Re: [PATCH,V1 07/14] readelf/objdump: support for SFrame section In-Reply-To: <20220930000440.1672106-8-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Indu, > This patch adds support for SFrame in readelf and objdump. There appear to be a couple of problems with the readelf implementation of this feature: 1. Just using the --sframe option on its own results in readelf saying that there is nothing to do: % ./readelf --sframe ../ld/tmpdir/sframe-bar.o readelf: Warning: Nothing to do. [...whole list of accepted command line options....] 2. Not providing a section name gives a slightly off error message: % ./readelf --sframe= ../ld/tmpdir/sframe-bar.o Section '' has no data to dump. I would have expected something along the lines of "section name must be provided". 3. Providing an incorrect section name does not result in any kind of error message, although the exit code is set to 1: % ./readelf --sframe=.eh_frame ../ld/tmpdir/sframe-bar.o % echo $? 1 One other minor point - it would be good to mention support for this new feature in the binutils/NEWS file. (I know that you have a patch for gas/NEWS, I just think that it should be mentioned here as well). Cheers Nick