From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by sourceware.org (Postfix) with ESMTPS id 3A23C3858C33 for ; Mon, 1 Aug 2022 11:36:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A23C3858C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=martin.st Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=martin.st Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 271BZrMW003150-271BZrMX003150; Mon, 1 Aug 2022 14:35:53 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 23B83A1468; Mon, 1 Aug 2022 14:35:53 +0300 (EEST) Date: Mon, 1 Aug 2022 14:35:53 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Nick Clifton cc: binutils@sourceware.org Subject: Re: [PATCH v3 1/2] ld: Add support for a new option, -exclude-symbols, in COFF object file directives In-Reply-To: <6dbbfb87-203c-9b38-a854-6b53fce223a9@redhat.com> Message-ID: <4ad2e256-f39c-cafe-3234-738eeffa23d5@martin.st> References: <20220728133737.4049560-1-martin@martin.st> <6dbbfb87-203c-9b38-a854-6b53fce223a9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-FE-Policy-ID: 3:14:2:SYSTEM X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 11:36:04 -0000 On Mon, 1 Aug 2022, Nick Clifton wrote: > Hi Martin, > >> This maps to the same as ld's --exclude-symbols command line option, >> but allowing specifying the option via directives embedded in the >> object files instead of passed manually on the command line. >> --- >> v2: Fixed parsing multiple comma separated symbols. While >> pe_dll_add_excludes >> does tokenize the string, the symbol tokens in deffilep.y don't >> include commas, so we need to handle that at that level. >> >> v3: Added an x86_64 testcase too, changed i*86 into i?86 in the testcases. > > Patch approved - please apply. Thanks! I don't have commit access, so can someone apply the patches for me? // Martin